Fix tracercontainer in flowexp_comp #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead pass TracerConfig reference to relevant member functions
|
jenkins build this please |
|
Thanks for the fixing. With some efforts, we probably can find the problematic change to understand the issue, but with the limited resource, I am happy it gets fixed. |
bska
approved these changes
Feb 27, 2025
|
yeah i know, i disabled both copy and move ctor / assignment but non of them triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot explain this, but this fixes the problem.
For some reason, we get calls to tracerC_ where the eclState_ reference member is nullptr. By not holding this as a member this is avoided. I cannot figure out how tracerC_ gets in such a state.