-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compositional well #6042
Draft
GitPaean
wants to merge
43
commits into
OPM:master
Choose a base branch
from
GitPaean:compositional_well
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Compositional well #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for CompWell
it is not clear what are needed there yet.
and we can not have zero mole fractions, so a mimium 1.e-8 is used to make the phase stability goes through.
based on the flash calculation results.
it looks like some re-organization of the variables and functions will be needed.
It looks like most of pieces are there.
so far, the values look correct, not sure why it does not converge.
it looks like might converged for the injector.
to avoid singular matrix
following the new way in the master branch.
…lWellModel not sure about the correctness yet.
but it looks like flowexp framework does not check the well convergence.
only outputting the bhp for the moment.
by adding extra well model fucntions to CompositionalWellModel
removing the hacking for testing.
using the compress factor
also helps to jenkins compile
562c784
to
af95308
Compare
05c2e72
to
6c43502
Compare
6c43502
to
e9518ed
Compare
most likely related to Schur Complement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of the well modeling for the compositional simulation.
The current version only supports BHP control, single perforation, and two phase, while the general facility is there.
Will try to cleaning up and add some more functionality before it goes in.
It depends on the upstream PR OPM/opm-common#4334 .