Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TracerModel: avoid setting up ILU if no solves will be performed #6045

Merged
merged 1 commit into from
Mar 4, 2025
Merged

TracerModel: avoid setting up ILU if no solves will be performed #6045

merged 1 commit into from
Mar 4, 2025

Conversation

akva2
Copy link
Member

@akva2 akva2 commented Mar 4, 2025

Mostly irrelevant, but why not?

Timings for NORNE_ATW2013 [5 runs]

Revision tracerAdvance tracerSolve Pre/post step p-value(tracerSolve)
tracer_avoid_ilu 32.55 +- 0.13 5.16 +- 0.00 55.03 +- 0.13 0
master 32.17 +- 0.23 5.34 +- 0.00 54.89 +- 0.51

Timings for NORNE_ATW2013_1A_MSW [5 runs]

Revision tracerAdvance tracerSolve Pre/post step p-value(tracerSolve)
tracer_avoid_ilu 32.76 +- 0.48 0.13 +- 0.00 59.05 +- 0.81 0
master 35.99 +- 0.42 3.10 +- 0.00 61.63 +- 0.66

@akva2
Copy link
Member Author

akva2 commented Mar 4, 2025

jenkins build this please

bska
bska reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use bitwise operations for bools. Other than that, this is fine.

@akva2 akva2 force-pushed the tracer_avoid_ilu branch from afc6128 to 59a71fd Compare March 4, 2025 13:33
@akva2
Copy link
Member Author

akva2 commented Mar 4, 2025

jenkins build this please

bska
bska approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates. This looks good to me now and I'll merge into master.

@bska bska merged commit 9db8cf7 into OPM:master Mar 4, 2025
1 check passed
@akva2 akva2 deleted the tracer_avoid_ilu branch March 5, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akva2 @bska