make nonlinear system possible to change #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
|
|
jenkins build this please |
GitPaean
reviewed
Mar 5, 2025
| @@ -25,7 +25,6 @@ | |||
| #define OPM_BLACKOILMODEL_PROPERTIES_HEADER_INCLUDED | |||
|
|
|||
| #include <opm/simulators/flow/FlowProblemBlackoilProperties.hpp> | |||
|
|
|||
There was a problem hiding this comment.
If you update, you can avoid deleting this line. It is not related to this PR.
|
It does not look like an interesting discussion. I am getting the PR in now since it is easy to adjust if needed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently nonlinear system is named BlackoilModel form BlackoilModel.hpp. This make it possible to use other nonlinear systems and or modify the behavoir of BlackoilModel in separate executables. Uses maybe: