Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all files from the 'examples' directory #65

Closed
wants to merge 1 commit into from
Closed

remove all files from the 'examples' directory #65

wants to merge 1 commit into from

Conversation

andlaus
Copy link
Contributor

@andlaus andlaus commented Apr 25, 2014

these used the EclipseGridParser but were not compiled. @rolk: If you
bother enough to keep them, please add them to the default build, make
them compile and work with the current code and ping me for the port
to opm-parser. (if you don't want to port this yourself.)

these used the EclipseGridParser but were not compiled. @rolk: If you
bother enough to keep them, please add them to the default build, make
them compile and work with the current code and ping me for the port
to opm-parser. (if you don't want to port this yourself.)
@rolk
Copy link
Member

rolk commented Apr 25, 2014

The reason they are not in the master build is two-fold: (1) it illustrates how you can setup a separate project that actually use opm-verteq, and (2) I don't fancy automatically building the examples when I make changes to the library. Deleting the files is not a solution.

@rolk rolk closed this Apr 25, 2014
@andlaus
Copy link
Contributor Author

andlaus commented Apr 26, 2014

I don't actually care if they are in the repo or not, but after EclipseGridParser has been removed (which currently seems to be in one or two weeks), they won't compile anymore and you have to port them to opm-parser yourself...

As a service, I'll do this for you if you add them to the default build...

@rolk
Copy link
Member

rolk commented Apr 28, 2014

after EclipseGridParser has been removed, they won't compile anymore and you have to port them to opm-parser yourself

That's OK; I have to figure out how to use opm-parser eventually anyway. Until OPM/opm-core#458 is looked into, opm-verteq is not particularily useful, so any "downtime" will have little impact at the moment.

@andlaus
Copy link
Contributor Author

andlaus commented Apr 28, 2014

okay, good. (That saves me some work. yay!)

@andlaus andlaus deleted the remove_examples branch April 28, 2014 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants