(feat) interpolated melt pool geom option - #40
Open
gknapp1 wants to merge 3 commits into
Open
Conversation
- For small cases this did not noticably change solution time - For a larger case, this changed time from 60 s to 232 s. Not great, so will try to fix that.
- Only marginally faster (~3-5%) but makes sense to be consistent between the codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements an option to use linear interpolation to find the liquid isotherm (
TL) before extraction the melt pool geometry. This provides a smoother response that is less sensitive to mesh geometry and provides a smoother convergence when refining the mesh.This is implemented as an additional feature to
MP_Stats(though largely uses the same logic under the hood, with only a couple logic branches), because I've noted this slows down the solution significantly (up to 4x!) and the increased resolution of melt pool geometry may not always be necessary.