-
Notifications
You must be signed in to change notification settings - Fork 7
Generalize the temperature scalar type for forward-mode AD #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samm-Py
wants to merge
7
commits into
ORNL-MDF:main
Choose a base branch
from
Samm-Py:scalar-template-ad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e985449
Add a Scalar template parameter to the heat solve for forward-mode AD
Samm-Py d087a00
Update applications/Finch_OTI.hpp
Samm-Py f0a907d
Update src/Finch_Grid.hpp
Samm-Py cad3a85
Address Sparrow integration review comments
MythicManSam 8ce26e5
Clarify scalar template comment
MythicManSam 470c38a
Avoid private Sparrow checkout in Finch CI
MythicManSam aaca526
Add a parameter sensitivity example
MythicManSam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,25 @@ | ||
| add_executable(finch SingleLayer.cpp) | ||
| target_link_libraries(finch Core) | ||
| install(TARGETS finch DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
|
|
||
| # Optional forward-mode AD sensitivity application. Sparrow is header-only, so | ||
| # its include directory is the complete dependency integration; no Sparrow | ||
| # library target is built or linked, and Finch itself never depends on it. | ||
| find_path(SPARROW_INCLUDE_DIR otinum/otinum.hpp | ||
| HINTS | ||
| ${SPARROW_DIR} | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../../Sparrow/include | ||
| DOC "Path to the Sparrow include directory") | ||
|
|
||
| if(SPARROW_INCLUDE_DIR) | ||
| message(STATUS "Finch sensitivity: Sparrow found at ${SPARROW_INCLUDE_DIR}") | ||
| add_executable(finch_sensitivity SingleLayer_Sensitivity.cpp) | ||
| target_link_libraries(finch_sensitivity Core) | ||
| target_compile_definitions(finch_sensitivity PRIVATE OTI_ENABLE_KOKKOS) | ||
| target_include_directories(finch_sensitivity PRIVATE | ||
| ${SPARROW_INCLUDE_DIR} | ||
| ${PROJECT_SOURCE_DIR}/integrations/sparrow) | ||
| install(TARGETS finch_sensitivity DESTINATION ${CMAKE_INSTALL_BINDIR}) | ||
| else() | ||
| message(STATUS "Finch sensitivity: Sparrow not found, skipping finch_sensitivity") | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,341 @@ | ||
| /**************************************************************************** | ||
| * Copyright (c) 2024 by Oak Ridge National Laboratory * | ||
| * All rights reserved. * | ||
| * * | ||
| * This file is part of Finch. Finch is distributed under a * | ||
| * BSD 3-clause license. For the licensing terms see the LICENSE file in * | ||
| * the top-level directory. * | ||
| * * | ||
| * SPDX-License-Identifier: BSD-3-Clause * | ||
| ****************************************************************************/ | ||
|
|
||
| /**************************************************************************** | ||
| * Parameter sensitivity of the Finch single-layer heat solve, by forward-mode | ||
| * AD. | ||
| * | ||
| * Runs the single-layer heat transport problem once with OTI-valued material | ||
| * and source parameters, obtaining d(QoI)/dp for every parameter from that one | ||
| * solve, then validates each derivative against a central finite difference | ||
| * built from two ordinary double solves per parameter. | ||
| ****************************************************************************/ | ||
|
|
||
| #include <array> | ||
| #include <cmath> | ||
| #include <cstdio> | ||
| #include <cstdlib> | ||
| #include <string> | ||
| #include <type_traits> | ||
| #include <vector> | ||
|
|
||
| #include <mpi.h> | ||
|
|
||
| #include <Kokkos_Core.hpp> | ||
|
|
||
| #include "Finch_Core.hpp" | ||
| #include "Finch_Sparrow.hpp" | ||
|
|
||
| namespace | ||
| { | ||
|
|
||
| constexpr int NP = Finch::Sensitivity::NumParameters; | ||
|
|
||
| // First-order OTI numbers: one variable per differentiated parameter. This | ||
| // application computes and reports gradients only; second derivatives are not | ||
| // evaluated. | ||
| using OTI = oti::otinum<NP, 1>; | ||
|
|
||
| template <class T> | ||
| MPI_Datatype mpi_datatype() | ||
| { | ||
| static_assert( std::is_same<T, float>::value || | ||
| std::is_same<T, double>::value, | ||
| "Sensitivity MPI reductions support float and double " | ||
| "coefficients" ); | ||
| if constexpr ( std::is_same<T, float>::value ) | ||
| return MPI_FLOAT; | ||
| else | ||
| return MPI_DOUBLE; | ||
| } | ||
|
|
||
| // Quantities of interest evaluated on the final temperature field. Both are | ||
| // smooth functionals of the field, which makes them meaningful finite- | ||
| // difference references. | ||
| template <class Scalar> | ||
| struct QoI | ||
| { | ||
| // Sum of temperature over all owned nodes. | ||
| Scalar sum; | ||
| // Temperature at a single fixed node (centre of the owned index space). | ||
| Scalar probe; | ||
| }; | ||
|
|
||
| // Run the transient solve to completion and evaluate the QoIs. | ||
| template <class Scalar, class MemorySpace, class ExecSpace> | ||
| QoI<Scalar> solve( MPI_Comm comm, Finch::Inputs db, | ||
| const Finch::SolverParameters<Scalar>& params ) | ||
| { | ||
| std::array<std::string, 6> bc_types = { "adiabatic", "adiabatic", | ||
| "adiabatic", "adiabatic", | ||
| "adiabatic", "adiabatic" }; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these boundary conditions come from the input file @streeve ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that would be a nice improvement |
||
|
|
||
| Finch::Grid<MemorySpace, Scalar> grid( | ||
| comm, db.space.cell_size, db.space.global_low_corner, | ||
| db.space.global_high_corner, db.space.ranks_per_dim, bc_types, | ||
| db.space.initial_temperature ); | ||
|
|
||
| auto fd = Finch::createSolver( db, grid, params ); | ||
|
|
||
| Finch::MovingBeam beam( db.source.scan_path_file ); | ||
|
|
||
| // Time loop. This mirrors Finch::Layer::step without the solidification | ||
| // sampling and file output, which are not needed for the QoIs here. | ||
| double time = db.time.start_time; | ||
| const double dt = db.time.time_step; | ||
|
|
||
| for ( int n = 0; n < db.time.num_steps; ++n ) | ||
| { | ||
| time += dt; | ||
|
|
||
| beam.move( time ); | ||
| double beam_power = beam.power(); | ||
| double beam_pos[3]; | ||
| for ( std::size_t d = 0; d < 3; ++d ) | ||
| beam_pos[d] = beam.position( d ); | ||
|
|
||
| auto T = grid.getTemperature(); | ||
| auto T0 = grid.getPreviousTemperature(); | ||
|
|
||
| Kokkos::deep_copy( T0, T ); | ||
|
|
||
| auto owned_space = grid.getIndexSpace(); | ||
| fd.solve( ExecSpace(), owned_space, T, T0, beam_power, beam_pos ); | ||
|
|
||
| grid.updateBoundaries(); | ||
| grid.gather(); | ||
| } | ||
|
|
||
| // Evaluate the sum on the active Kokkos backend. For the OTI solve this | ||
| // deliberately reduces a compound Sparrow scalar, exercising its device | ||
| // annotations, additive identity, and operator+= integration with Kokkos. | ||
| auto T = grid.getTemperature(); | ||
| auto owned = grid.getIndexSpace(); | ||
|
|
||
| QoI<Scalar> q; | ||
| q.sum = Scalar( 0 ); | ||
| Cabana::Grid::grid_parallel_reduce( | ||
| "sensitivity_temperature_sum", ExecSpace(), owned, | ||
| KOKKOS_LAMBDA( const int i, const int j, const int k, | ||
| Scalar& local_sum ) { | ||
| local_sum += T( i, j, k, 0 ); | ||
| }, | ||
| q.sum ); | ||
|
|
||
| // Copy only the single probe value to the host rather than mirroring the | ||
| // complete field. A rank-zero view keeps this path valid for device-only | ||
| // memory spaces. | ||
| const int probe_i = ( owned.min( 0 ) + owned.max( 0 ) ) / 2; | ||
| const int probe_j = ( owned.min( 1 ) + owned.max( 1 ) ) / 2; | ||
| const int probe_k = ( owned.min( 2 ) + owned.max( 2 ) ) / 2; | ||
| auto probe_device = Kokkos::subview( T, probe_i, probe_j, probe_k, 0 ); | ||
| auto probe_host = Kokkos::create_mirror_view_and_copy( Kokkos::HostSpace(), | ||
| probe_device ); | ||
| q.probe = probe_host(); | ||
|
|
||
| // Reduce the sum across ranks. An OTI number is a contiguous block of | ||
| // coefficients, and summing OTI numbers is summing coefficients | ||
| // elementwise, so a plain MPI reduction over ncoeffs coefficient values is | ||
| // exact -- no derived datatype or user-defined operator is required. | ||
| int comm_size; | ||
| MPI_Comm_size( comm, &comm_size ); | ||
| if ( comm_size > 1 ) | ||
| { | ||
| if constexpr ( std::is_same<Scalar, double>::value ) | ||
| { | ||
| double local = q.sum; | ||
| MPI_Allreduce( &local, &q.sum, 1, MPI_DOUBLE, MPI_SUM, comm ); | ||
| } | ||
| else | ||
| { | ||
| using coeff_type = typename Scalar::coeff_type; | ||
| Scalar local = q.sum; | ||
| MPI_Allreduce( &local[0], &q.sum[0], Scalar::ncoeffs, | ||
| mpi_datatype<coeff_type>(), MPI_SUM, comm ); | ||
| } | ||
| } | ||
|
|
||
| return q; | ||
| } | ||
|
|
||
| void run( MPI_Comm comm, int argc, char* argv[] ) | ||
| { | ||
| using exec_space = Kokkos::DefaultExecutionSpace; | ||
| using memory_space = exec_space::memory_space; | ||
|
|
||
| int rank; | ||
| MPI_Comm_rank( comm, &rank ); | ||
|
|
||
| Finch::Inputs db( comm, argc, argv ); | ||
|
|
||
| auto nominal = Finch::Sensitivity::nominal( db ); | ||
|
|
||
| // FD step is overridable so the derivative can be checked for step-size | ||
| // independence -- the standard way to tell a genuine discrepancy from a | ||
| // finite-difference artifact. | ||
| double rel_step = 1e-6; | ||
| if ( const char* s = std::getenv( "FINCH_FD_STEP" ) ) | ||
| rel_step = std::atof( s ); | ||
|
|
||
| // Warm up: the first solve of a process pays for page faults and OpenMP | ||
| // thread start-up, which would otherwise be charged to whichever solve | ||
| // happens to run first. | ||
| { | ||
| std::array<double, NP> warm; | ||
| for ( int i = 0; i < NP; ++i ) | ||
| warm[i] = nominal[i]; | ||
| Finch::Inputs warm_db = db; | ||
| warm_db.time.num_steps = 2; | ||
| solve<double, memory_space, exec_space>( | ||
| comm, warm_db, Finch::Sensitivity::build<double>( warm ) ); | ||
| } | ||
|
|
||
| // ---- One OTI solve gives every derivative ----------------------------- | ||
| double t0 = MPI_Wtime(); | ||
| auto seeded = Finch::Sensitivity::seed<OTI>( db ); | ||
| auto oti_result = solve<OTI, memory_space, exec_space>( | ||
| comm, db, Finch::Sensitivity::build<OTI>( seeded ) ); | ||
| double t_oti = MPI_Wtime() - t0; | ||
|
|
||
| // ---- Reference: one plain double solve, then two per parameter -------- | ||
| t0 = MPI_Wtime(); | ||
| std::array<double, NP> base; | ||
| for ( int i = 0; i < NP; ++i ) | ||
| base[i] = nominal[i]; | ||
| auto ref = solve<double, memory_space, exec_space>( | ||
| comm, db, Finch::Sensitivity::build<double>( base ) ); | ||
| double t_double = MPI_Wtime() - t0; | ||
|
|
||
| std::array<double, NP> fd_sum, fd_probe; | ||
| t0 = MPI_Wtime(); | ||
| for ( int i = 0; i < NP; ++i ) | ||
| { | ||
| double h = rel_step * std::fabs( nominal[i] ); | ||
|
|
||
| auto plus = base; | ||
| plus[i] = nominal[i] + h; | ||
| auto qp = solve<double, memory_space, exec_space>( | ||
| comm, db, Finch::Sensitivity::build<double>( plus ) ); | ||
|
|
||
| auto minus = base; | ||
| minus[i] = nominal[i] - h; | ||
| auto qm = solve<double, memory_space, exec_space>( | ||
| comm, db, Finch::Sensitivity::build<double>( minus ) ); | ||
|
|
||
| fd_sum[i] = ( qp.sum - qm.sum ) / ( 2.0 * h ); | ||
| fd_probe[i] = ( qp.probe - qm.probe ) / ( 2.0 * h ); | ||
| } | ||
| double t_fd = MPI_Wtime() - t0; | ||
|
|
||
| if ( rank != 0 ) | ||
| return; | ||
|
|
||
| // ---- Report ----------------------------------------------------------- | ||
| std::printf( "\n" ); | ||
| std::printf( "=================================================" | ||
| "=================================\n" ); | ||
| std::printf( " Finch parameter sensitivity: OTI forward-mode AD vs " | ||
| "central finite differences\n" ); | ||
| std::printf( "=================================================" | ||
| "=================================\n" ); | ||
| std::printf( " algebra : oti::otinum<%d,%d> (%d coefficients " | ||
| "per node)\n", | ||
| OTI::nvars, OTI::order, OTI::ncoeffs ); | ||
| std::printf( " time steps : %d\n", db.time.num_steps ); | ||
| std::printf( " FD relative step : %g\n", rel_step ); | ||
| std::printf( "\n" ); | ||
| std::printf( " value check T_sum OTI %.10e double %.10e\n", | ||
| oti_result.sum.real(), ref.sum ); | ||
| std::printf( " value check T_probe OTI %.10e double %.10e\n", | ||
| oti_result.probe.real(), ref.probe ); | ||
| std::printf( "\n" ); | ||
|
|
||
| const char* qoi_name[2] = { "T_sum [K]", "T_probe[K]" }; | ||
|
|
||
| for ( int q = 0; q < 2; ++q ) | ||
| { | ||
| const OTI& oti_number = | ||
| ( q == 0 ) ? oti_result.sum : oti_result.probe; | ||
| const std::array<double, NP>& fd = ( q == 0 ) ? fd_sum : fd_probe; | ||
|
|
||
| std::printf( " d(%s)/dp\n", qoi_name[q] ); | ||
| std::printf( " %-22s %16s %16s %11s %14s\n", "parameter", "OTI", | ||
| "central FD", "rel.diff", "p*dQ/dp [K]" ); | ||
| std::printf( " %-22s %16s %16s %11s %14s\n", "----------------------", | ||
| "----------------", "----------------", "-----------", | ||
| "--------------" ); | ||
|
|
||
| // A relative difference is only meaningful if the derivative is itself | ||
| // non-negligible. Compare each row against the largest normalized | ||
| // sensitivity in the table so that a structurally-zero derivative is | ||
| // reported as such rather than as a 100% disagreement. | ||
| double ref = 0.0; | ||
| for ( int i = 0; i < NP; ++i ) | ||
| { | ||
| typename OTI::alpha_type alpha{}; | ||
| alpha[i] = 1; | ||
| ref = std::max( | ||
| ref, std::fabs( nominal[i] * oti_number.partial( alpha ) ) ); | ||
| } | ||
|
|
||
| for ( int i = 0; i < NP; ++i ) | ||
| { | ||
| typename OTI::alpha_type alpha{}; | ||
| alpha[i] = 1; | ||
| double d_oti = oti_number.partial( alpha ); | ||
|
|
||
| double scale = std::max( std::fabs( d_oti ), std::fabs( fd[i] ) ); | ||
| bool negligible = nominal[i] != 0.0 && | ||
| std::fabs( nominal[i] ) * scale < 1e-8 * ref; | ||
|
|
||
| char label[64]; | ||
| std::snprintf( label, sizeof( label ), "%s [%s]", | ||
| Finch::Sensitivity::name( i ), | ||
| Finch::Sensitivity::units( i ) ); | ||
|
|
||
| std::printf( " %-22s %16.6e %16.6e ", label, d_oti, fd[i] ); | ||
| if ( negligible ) | ||
| std::printf( "%11s ", "negligible" ); | ||
| else if ( scale > 0.0 ) | ||
| std::printf( "%11.2e ", std::fabs( d_oti - fd[i] ) / scale ); | ||
| else | ||
| std::printf( "%11s ", "-" ); | ||
| std::printf( "%14.4e\n", nominal[i] * d_oti ); | ||
| } | ||
| std::printf( "\n" ); | ||
| } | ||
|
|
||
| std::printf( " cost: 1 OTI solve %.3f s | 1 double solve %.3f s" | ||
| " | %d FD solves %.3f s\n", | ||
| t_oti, t_double, 2 * NP, t_fd ); | ||
| std::printf( " OTI overhead vs one double solve: %.2fx " | ||
| "(all %d derivatives)\n", | ||
| t_oti / t_double, NP ); | ||
| std::printf( " FD cost for the same %d derivatives: %.2fx\n", NP, | ||
| t_fd / t_double ); | ||
| std::printf( "=================================================" | ||
| "=================================\n\n" ); | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| int main( int argc, char* argv[] ) | ||
| { | ||
| MPI_Init( &argc, &argv ); | ||
| Kokkos::initialize( argc, argv ); | ||
|
|
||
| run( MPI_COMM_WORLD, argc, argv ); | ||
|
|
||
| Kokkos::finalize(); | ||
| MPI_Finalize(); | ||
|
|
||
| return 0; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think
SingleLayer_Sensitivity.cppis more clearThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!