Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airocean projection (formerly Dymaxion) #4303

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

plouvart
Copy link

@plouvart plouvart commented Nov 1, 2024

  • Closes Add Dymaxion/Fuller Projection #232
  • Tests added
  • Added clear title that can be used to generate release notes
  • Fully documented, including updating docs/source/*.rst for new API

@plouvart plouvart changed the title Add Airocean projection (formerly Dymaxion) #232 Add Airocean projection (formerly Dymaxion) Nov 1, 2024
src/projections/airocean.cpp Outdated Show resolved Hide resolved
src/projections/airocean.cpp Show resolved Hide resolved
@plouvart
Copy link
Author

plouvart commented Nov 1, 2024

Seems like cppcheck is complaining about some unused variable, despite the fact that it is used next line.
Edit: just saw your fix above :)

@rouault rouault added this to the 9.6.0 milestone Nov 1, 2024
@rouault
Copy link
Member

rouault commented Nov 1, 2024

A few typos in the doc reported in https://github.com/OSGeo/PROJ/actions/runs/11632419978/job/32395481110?pr=4303 . For words which are legitimate and must be allowed, you can add them in docs/source/spelling_wordlist.txt

@plouvart
Copy link
Author

plouvart commented Nov 1, 2024

Thanks for the fix for the out of projection domain error

accept 5200000 26800000
expect 123.33794956763194 6.861286881197438
accept 2600000 22300000
expect 147.63769509437498 15.818879769693432
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plouvart could you add a test point that triggers the out-of-projection-domain error ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'll do that in a few minutes

Comment on lines +43 to +45
The airocean map of the whole globe has an extent of approximately
:math:`[0, 0, 17404000, 36844000]` in meters. Although the airocean map has no
true up or down, the choice was made to lay it out vertically, from Antarctica to Australia.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be neat to have a +orient=<string> parameter to control this aspect, where "vertical" would be the current layout and "horizontal" would be the classic layout with Australia on the left and Antarctica on the right.

Copy link
Member

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and comments below.

+---------------------+----------------------------------------------------------+
| **Classification** | Polyhedral, equal area |
+---------------------+----------------------------------------------------------+
| **Available forms** | Forward and inverse, spherical |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PROJ_HEAD has "Sph&Ell" and it appears that ellipsoidal forms are supported, so should the docs reflect this?

Suggested change
| **Available forms** | Forward and inverse, spherical |
| **Available forms** | Forward and inverse, spherical and ellipsoidal |

@@ -73,6 +73,18 @@ @TechReport{Deakin2004
Url = {http://www.mygeodesy.id.au/documents/Molodensky%20V2.pdf}
}

@Article{Gray1995,
Title = {Exact Transformation Equations for Fuller's World Map},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserve title case for BibTeX via:

Suggested change
Title = {Exact Transformation Equations for Fuller's World Map},
Title = {Exact Transformation Equations for {Fuller's World Map}},


Original Reference:
Robert W. Gray (1995) Exact Transformation Equations for
Fuller's World Map, Vol. 32. Autumn, 1995, pp. 17-25.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fuller's World Map, Vol. 32. Autumn, 1995, pp. 17-25.
Fuller's World Map. Cartographica, 32(3), 17-25.
https://doi.org/10.3138/1677-3273-Q862-1885

@plouvart
Copy link
Author

plouvart commented Nov 6, 2024

@mwtoews I saw your comments. Those fixes seem fair. I'll get on those as soon as a I have some free time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dymaxion/Fuller Projection
3 participants