-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airocean projection (formerly Dymaxion) #4303
base: master
Are you sure you want to change the base?
Conversation
… and orientation.
…on (dym). Remove unused constants. Change sqrtl to sqrt.
Seems like cppcheck is complaining about some unused variable, despite the fact that it is used next line. |
A few typos in the doc reported in https://github.com/OSGeo/PROJ/actions/runs/11632419978/job/32395481110?pr=4303 . For words which are legitimate and must be allowed, you can add them in docs/source/spelling_wordlist.txt |
Thanks for the fix for the out of projection domain error |
accept 5200000 26800000 | ||
expect 123.33794956763194 6.861286881197438 | ||
accept 2600000 22300000 | ||
expect 147.63769509437498 15.818879769693432 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plouvart could you add a test point that triggers the out-of-projection-domain error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll do that in a few minutes
The airocean map of the whole globe has an extent of approximately | ||
:math:`[0, 0, 17404000, 36844000]` in meters. Although the airocean map has no | ||
true up or down, the choice was made to lay it out vertically, from Antarctica to Australia. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be neat to have a +orient=<string>
parameter to control this aspect, where "vertical" would be the current layout and "horizontal" would be the classic layout with Australia on the left and Antarctica on the right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and comments below.
+---------------------+----------------------------------------------------------+ | ||
| **Classification** | Polyhedral, equal area | | ||
+---------------------+----------------------------------------------------------+ | ||
| **Available forms** | Forward and inverse, spherical | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PROJ_HEAD
has "Sph&Ell" and it appears that ellipsoidal forms are supported, so should the docs reflect this?
| **Available forms** | Forward and inverse, spherical | | |
| **Available forms** | Forward and inverse, spherical and ellipsoidal | |
@@ -73,6 +73,18 @@ @TechReport{Deakin2004 | |||
Url = {http://www.mygeodesy.id.au/documents/Molodensky%20V2.pdf} | |||
} | |||
|
|||
@Article{Gray1995, | |||
Title = {Exact Transformation Equations for Fuller's World Map}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve title case for BibTeX via:
Title = {Exact Transformation Equations for Fuller's World Map}, | |
Title = {Exact Transformation Equations for {Fuller's World Map}}, |
|
||
Original Reference: | ||
Robert W. Gray (1995) Exact Transformation Equations for | ||
Fuller's World Map, Vol. 32. Autumn, 1995, pp. 17-25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuller's World Map, Vol. 32. Autumn, 1995, pp. 17-25. | |
Fuller's World Map. Cartographica, 32(3), 17-25. | |
https://doi.org/10.3138/1677-3273-Q862-1885 |
@mwtoews I saw your comments. Those fixes seem fair. I'll get on those as soon as a I have some free time |
docs/source/*.rst
for new API