libcsf: address (false positive) Coverity warnings #11346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity Scan has false positives about calls to CsfGetAttrIndex() that might return NR_ATTR_IN_BLOCK whereas they can not. Adding a CsfGetAttrBlockAndIdx() function that returns both the block and index should make it happy.
|
Hi Even. Thanks for your patch. My colleague Oliver Schmitz (@OliverSchmitz) will have a look at it. He is the principle maintainer of PCRaster. CSF is PCRaster's native raster format. |
|
Hello Even, the modifications look reasonable. I also checked them with our PCRaster builds, all tests pass. Should be fine to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity Scan has false positives about calls to CsfGetAttrIndex() that might return NR_ATTR_IN_BLOCK whereas they can not. Adding a CsfGetAttrBlockAndIdx() function that returns both the block and index should make it happy.
@kordejong can you double check that?