Remove static/ directory and update frontend deployment docs #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup on commit 2991254 which removed the management commands necessary for serving the frontend via Django. The supported workflow is now to deploy the frontend separately and configure it to talk to this Django app. If desired, both can be served by an Nginx proxy (which serves static files for the frontend and proxies /api requests to Django).
willemarcel
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on commit 2991254 which removed the management commands necessary for serving the frontend via Django. The supported workflow is now to deploy the frontend separately and configure it to talk to this Django app. If desired, both can be served by an Nginx proxy (which serves static files for the frontend and proxies /api requests to Django).
I also changed some tuples in the Django settings module to lists, to match the documented types of those settings in Django's docs.