Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored EK80 data XML parser and also removed the usage of dict_to_dict method #1186

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

praneethratna
Copy link
Contributor

@praneethratna praneethratna commented Oct 2, 2023

Fixes #468 by improving parsing for EK80 XML data and also removed the usage of dict_to_dict method, also Fixes #1184 and now 'PingSequence' XML datagram is parsed and stored in the output of open_raw.

CC @leewujung @emiliom

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: Patch coverage is 90.42553% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (0bc534e) to head (ea66098).
Report is 87 commits behind head on dev.

Files with missing lines Patch % Lines
echopype/convert/utils/ek_raw_parsers.py 90.21% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1186      +/-   ##
==========================================
- Coverage   77.04%   67.85%   -9.20%     
==========================================
  Files          67       19      -48     
  Lines        5908     3080    -2828     
==========================================
- Hits         4552     2090    -2462     
+ Misses       1356      990     -366     
Flag Coverage Δ
unittests 67.85% <90.42%> (-9.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leewujung leewujung requested review from leewujung and removed request for emiliom October 18, 2023 18:49
@leewujung leewujung added this to the 0.8.3 milestone Nov 20, 2023
@leewujung leewujung modified the milestones: 0.8.3, v0.8.4 Mar 14, 2024
@leewujung leewujung modified the milestones: v0.8.4, v0.9.0 Apr 22, 2024
@ctuguinay ctuguinay modified the milestones: v0.9.0, v0.9.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data conversion enhancement This makes echopype better
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants