RES generation and capacity target updates #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added nodal level generation targets. Can now be set at both country and nodal level, for all RES technologies or as a subset of said technologies. -Added nodal level RES capacity targets. For the time being can only be set per node and technology.
-Moved calibration to power plant -Removed max_capacity.py -Removed redundant 'powerplant_build_rates' and 'fuel_limits' config parameters.
trevorb1
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks really great, @maartenbrinkerink! No critical issues that must be solved before merging, as most my suggestions are just minor code changes that do not change functionality. I was able to run the workflow with a couple different configuration files as well.
The only note that may require attention is the comment in the config file about RE targets. I guess depending on the case studies, it may be nice to define RE targets at a system level, rather than just a node/country level to better showcase the potential of interconnectors?
workflow/scripts/osemosys_global/emissions/emission_activity_ratio.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/emissions/emission_activity_ratio.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/emissions/emission_activity_ratio.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/renewable_targets.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/renewable_targets.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Ticket Number
#229