-
Notifications
You must be signed in to change notification settings - Fork 17
Make left sidebar and right column fill full viewport height with scrollable regions #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
11
commits into
main
Choose a base branch
from
copilot/make-left-column-scrollable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+153
−45
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8e32270
Initial plan
Copilot 53595ed
Make left column scrollable at page height by adding md:overflow-y-au…
Copilot 7f1ec15
Fix sidebar scroll: change body min-h-screen to h-screen overflow-hidden
Copilot b23da1a
Move footer into right-column wrapper so sidebar and content fill ful…
Copilot 1abc810
Merge branch 'main' into copilot/make-left-column-scrollable
DonnieBLT 2b2fa13
Move footer inside main so it scrolls with content, not pinned to bottom
Copilot b1a7e0f
Merge branch 'main' into copilot/make-left-column-scrollable
DonnieBLT 2676175
Add resizable sidebar, thin red scrollbars hidden until hover, fix in…
Copilot 89eab47
Make table thead sticky so column headers stay visible while scrollin…
Copilot a4e3fab
Merge branch 'main' into copilot/make-left-column-scrollable
DonnieBLT eab99de
Merge branch 'main' into copilot/make-left-column-scrollable
DonnieBLT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is inconsistent for the wrapper div and its children. The
mainelement (line 508) andfooterelement (line 540) should be indented more than their parentdivelement (line 507), as they are child elements. While this doesn't affect functionality, consistent indentation improves code readability and maintainability.