Skip to content

fix: replace leaked exception details with generic error messages #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SatishKumar620 wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −19
Open

fix: replace leaked exception details with generic error messages #287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb3f601
fix: replace leaked exception details with generic error messages
SatishKumar620 Mar 16, 2026
3921b58
fix: replace leaked exception details with generic error messages
SatishKumar620 Mar 16, 2026
87807f6
fix: replace str(e) with e in f-string, add error logging before org …
SatishKumar620 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ async def handle_add_pr(request, env):
if 'status=403' in error_msg:
return Response.new(json.dumps({'error': 'Rate Limit Exceeded'}),
{'status': 403, 'headers': {'Content-Type': 'application/json'}})
return Response.new(json.dumps({'error': f'Failed to fetch organization repos: {error_msg}'}),
return Response.new(json.dumps({'error': 'Failed to fetch organization repos'}),
{'status': 400, 'headers': {'Content-Type': 'application/json'}})

if not org_repos:
Expand Down Expand Up @@ -418,7 +418,7 @@ def get_sort_expression(col_name):
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_list_prs'})
return Response.new(
json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}}
)

Expand Down Expand Up @@ -448,7 +448,7 @@ async def handle_list_repos(env):
}})
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_list_repos'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})

async def handle_list_authors(env):
Expand All @@ -474,7 +474,7 @@ async def handle_list_authors(env):
}})
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_list_authors'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})


Expand Down Expand Up @@ -601,7 +601,7 @@ async def handle_refresh_pr(request, env):

except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_refresh_pr'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})

async def handle_batch_refresh_prs(request, env):
Expand Down Expand Up @@ -690,7 +690,7 @@ async def handle_batch_refresh_prs(request, env):
updated_prs.append({'pr_id': pr_id, 'pr_number': pr_number})
except Exception as update_error:
print(f"Error updating PR #{pr_number} in {owner}/{repo}: {str(update_error)}")
errors.append({'pr_id': pr_id, 'pr_number': pr_number, 'error': str(update_error)})
errors.append({'pr_id': pr_id, 'pr_number': pr_number, 'error': 'Update failed'})

return Response.new(json.dumps({
'success': True,
Expand All @@ -705,7 +705,7 @@ async def handle_batch_refresh_prs(request, env):

except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_batch_refresh_prs'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})

async def handle_refresh_org(request, env):
Expand Down Expand Up @@ -736,7 +736,7 @@ async def handle_refresh_org(request, env):
if 'status=403' in error_msg:
return Response.new(json.dumps({'error': 'Rate Limit Exceeded'}),
{'status': 403, 'headers': {'Content-Type': 'application/json'}})
return Response.new(json.dumps({'error': f'Failed to fetch organization repos: {error_msg}'}),
return Response.new(json.dumps({'error': 'Failed to fetch organization repos'}),
{'status': 400, 'headers': {'Content-Type': 'application/json'}})

if not org_repos:
Expand Down Expand Up @@ -828,7 +828,7 @@ async def handle_refresh_org(request, env):

except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_refresh_org'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})


Expand Down Expand Up @@ -868,7 +868,7 @@ async def handle_rate_limit(env):
print(f"Error in handle_rate_limit: {str(e)}")
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_rate_limit'})
return Response.new(
json.dumps({'error': 'Internal server error fetching rate status'}),
json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}}
)

Expand Down Expand Up @@ -898,7 +898,7 @@ def _row_to_dict(r):
# Database not configured
return Response.new(json.dumps({
'database_configured': False,
'error': str(e),
'error': 'Database not configured',
'environment': getattr(env, 'ENVIRONMENT', 'unknown'),
'row_counts': {
'prs': 0,
Expand Down Expand Up @@ -943,7 +943,7 @@ async def handle_pr_updates_check(env):
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_pr_updates_check'})
return Response.new(
json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}}
)

Expand Down Expand Up @@ -974,7 +974,7 @@ async def handle_get_pr(env, pr_id):
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_get_pr'})
return Response.new(
json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}}
)

Expand Down Expand Up @@ -1328,7 +1328,7 @@ async def handle_github_webhook(request, env):
print(f"Error handling webhook: {type(e).__name__}: {str(e)}")
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_github_webhook'})
return Response.new(
json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}}
)

Expand Down Expand Up @@ -1423,7 +1423,7 @@ async def handle_pr_timeline(request, env, path):
{'headers': {'Content-Type': 'application/json'}})
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_pr_timeline'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})

async def handle_pr_review_analysis(request, env, path):
Expand Down Expand Up @@ -1530,7 +1530,7 @@ async def handle_pr_review_analysis(request, env, path):
{'headers': {'Content-Type': 'application/json'}})
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_pr_review_analysis'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})

async def _run_readiness_analysis(env, pr, pr_id, github_token):
Expand Down Expand Up @@ -1707,7 +1707,7 @@ async def handle_pr_readiness(request, env, path):
)
except Exception as e:
await notify_slack_exception(getattr(env, 'SLACK_ERROR_WEBHOOK', ''), e, context={'handler': 'handle_pr_readiness'})
return Response.new(json.dumps({'error': f"{type(e).__name__}: {str(e)}"}),
return Response.new(json.dumps({'error': 'Internal server error'}),
{'status': 500, 'headers': {'Content-Type': 'application/json'}})


Expand Down
Loading