Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test #67

Closed
wants to merge 16 commits into from
Closed

added test #67

wants to merge 16 commits into from

Conversation

Sarthak5598
Copy link
Member

No description provided.

@Sarthak5598
Copy link
Member Author

Please let me know if this needs more functionality!

DonnieBLT
DonnieBLT approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what else we can test but this looks good to me

@Sarthak5598
Copy link
Member Author

Sure!, We can test the team_joins but the issue is we need to make mails to test and it will be complex and our functionality is pretty basic

@Sarthak5598
Copy link
Member Author

image
Hey @arkid15r I am not sure why is it giving this error , I tried using fixture and even made event_data within the function but its still giving the same error

@Sarthak5598
Copy link
Member Author

Works now It was a poetry related issue, still gives warning ,
image
is there something I should look into for this ?

@DonnieBLT
Copy link
Contributor

I would say debug / trace the code or add print statements to figure out where it errors

@Sarthak5598
Copy link
Member Author

Sure!

arkid15r
arkid15r reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings on the screenshot are deprecation ones. All you can do is migrate to the recommended alternative.

.github/workflows/ci-cd.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should modify this file for tests implementation

arkid15r
arkid15r reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems tests don't work -- look into mocking SIGNING_SECRET and whatever is needed to bootstrap the app.

@DonnieBLT DonnieBLT closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@DonnieBLT DonnieBLT DonnieBLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sarthak5598 @DonnieBLT @arkid15r