-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test #67
added test #67
Conversation
Please let me know if this needs more functionality! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what else we can test but this looks good to me
Sure!, We can test the team_joins but the issue is we need to make mails to test and it will be complex and our functionality is pretty basic |
…into adding-tests
|
I would say debug / trace the code or add print statements to figure out where it errors |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warnings on the screenshot are deprecation ones. All you can do is migrate to the recommended alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should modify this file for tests implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems tests don't work -- look into mocking SIGNING_SECRET
and whatever is needed to bootstrap the app.
No description provided.