-
-
Notifications
You must be signed in to change notification settings - Fork 304
Added Redirection Rules #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Redirection Rules #2690
Conversation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughMoved snapshot pages and API route under the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-07-12T17:36:57.255ZApplied to files:
📚 Learning: 2025-11-17T16:47:05.578ZApplied to files:
📚 Learning: 2025-11-17T17:30:42.139ZApplied to files:
📚 Learning: 2025-07-13T07:31:06.511ZApplied to files:
🧬 Code graph analysis (1)frontend/src/app/community/snapshots/layout.tsx (1)
🔇 Additional comments (5)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
proxy/redirects.conf (1)
8-10: Functionally correct; consider style consistency.The redirect logic works correctly. Using
$request_uriproperly handles all/snapshots/*paths and preserves query strings.However, for style consistency with lines 1-3 and lines 4-6, consider this alternative approach:
-location ^~ /snapshots/ { - return 301 /community$request_uri; -} +location ^~ /snapshots/ { + return 301 /community/snapshots/$1$is_args$args; +}Wait, that won't work without regex capture. Actually, your current implementation using
$request_uriis the cleaner approach for this use case. The minor style inconsistency is acceptable since the alternative would require a regex location with capture groups.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
proxy/redirects.conf(1 hunks)
🔇 Additional comments (1)
proxy/redirects.conf (1)
4-6: LGTM! Exact match redirect correctly implemented.The redirect for
/snapshotsto/community/snapshotsis correctly implemented, preserving query strings with$is_args$argsand following the established pattern in this file.
arkid15r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a single PR for all issue related changes.
|
Ping me when you update the PR. Thank you. |
|
rudransh-shrivastava
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "/releases": release_router, | ||
| "/repositories": repository_router, | ||
| "/snapshots": snapshot_router, | ||
| "/community/snapshots": snapshot_router, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can revert changes to the Nest v0 API.




Proposed change
Resolves #2622
Add the PR description here.
Added redirect rules in redirect.conf
Checklist
make check-testlocally; all checks and tests passed.