Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown to PDF workflow automation #391

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

talesh
Copy link
Collaborator

@talesh talesh commented Jul 24, 2024

PR Checklist 🚨

It is intended that only defined "vulnerability entry leads" should be able to create PR's (See CODEOWNERS and Core Team)

If you are not a CODEOWNER for the entry of artifact, please see our Issues and Discussions boards

Proposed changes

Added:

  • Added markdown-to-pdf shell script to generate PDFs from markdown files
  • Added header information to LLM00_Introduction markdown files
  • Added Github action to regenerate PDFs and create zip of in Action artifacts when changes are made to translation folders.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have x-referenced the appropriate issue this addresses within the projects board
  • I have applied the relevant labels this PR addresses

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Collaborator

@GangGreenTemperTatum GangGreenTemperTatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run these unit tests on this branch to validate a working solution?

@talesh
Copy link
Collaborator Author

talesh commented Jul 24, 2024

I am unsure what you mean by "unit tests", but I'm guessing you'd like to run the Github workflow in a separate branch. If you want to run it in a separate branch rather than main/master I can definitely make that modification to run on on a 'translations' branch.

Please confirm and I'll make that modification.

@GangGreenTemperTatum
Copy link
Collaborator

I am unsure what you mean by "unit tests", but I'm guessing you'd like to run the Github workflow in a separate branch. If you want to run it in a separate branch rather than main/master I can definitely make that modification to run on on a 'translations' branch.

Please confirm and I'll make that modification.

thank you for the awesome contribution! i guess we can never control the branch so we cannot go that route
i'll approve and i guess we can debug without numerous PRs if we run into problems

@GangGreenTemperTatum GangGreenTemperTatum merged commit 01d28b1 into OWASP:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants