Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for validation files in custom paths #138

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

ncerutti
Copy link
Contributor

@ncerutti ncerutti commented Sep 3, 2024

Validation files in custom paths

When a custom path is passed in the configuration file, validation files in that folder will be found and used.

Validation files have to be provided in the appropriate format and filename. Failed validations will no longer interrupt the conversion, but will provide a warning message.

Solves #139.

@ncerutti ncerutti changed the title Feature/validationpath Look for validation files in custom paths Sep 4, 2024
@ncerutti ncerutti self-assigned this Sep 4, 2024
@ncerutti ncerutti linked an issue Sep 4, 2024 that may be closed by this pull request
@ncerutti ncerutti requested a review from benhayes21 September 4, 2024 13:28
@ncerutti ncerutti marked this pull request as ready for review September 4, 2024 15:03
@sambles sambles mentioned this pull request Sep 5, 2024
@sambles sambles merged commit 5c9a9ed into main Sep 19, 2024
14 checks passed
@sambles sambles deleted the feature/validationpath branch September 19, 2024 09:43
sambles pushed a commit that referenced this pull request Sep 19, 2024
* add optional folders to validator paths

* capture specific errors in validation, comments

* pep

* pep

* remove lark version pin
@awsbuild awsbuild added this to the 3.2.7 milestone Sep 19, 2024
@awsbuild awsbuild modified the milestones: 3.2.7, 3.2.8 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Look for validation files in custom paths
4 participants