Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cybermodels support in the OasisAPI - V1 Only #1133

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Oct 31, 2024

Add cybermodels support in the OasisAPI - V1 Only

  • Only for run_mode = V1 allow input generation to work without posting a location.csv file.
  • Update the check in portfolios to allow execution if Either a location or an account file is attached.

@sambles sambles linked an issue Oct 31, 2024 that may be closed by this pull request
@sambles sambles mentioned this pull request Oct 31, 2024
@sambles sambles changed the title Add cybermodels support in the OasisAPI - V1 Add cybermodels support in the OasisAPI - V1 Only Oct 31, 2024
@sambles sambles merged commit a585706 into main Oct 31, 2024
26 of 27 checks passed
@sambles sambles deleted the feature/cybermodels-support branch October 31, 2024 17:09
sambles added a commit that referenced this pull request Oct 31, 2024
* tmp

* retun checks for V2 runs

* Only block input generation with a missing loc file on run_mode = V2

* Revert "retun checks for V2 runs"

This reverts commit 925474d.

* fix

* Update error in v2 test

* Fix testing and validation

* update port val messages
@awsbuild awsbuild added this to the 2.3.10 milestone Oct 31, 2024
@awsbuild awsbuild modified the milestones: 2.3.10, 2.3.11 Nov 28, 2024
@awsbuild awsbuild modified the milestones: 2.3.11, 2.4.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support Cyber models on OasisPlatform
2 participants