-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build-release-binaries workflow #3484
base: main
Are you sure you want to change the base?
Conversation
- Pin ubuntu runner to 24.04 for stability - Add architecture labels to checksum file for clarity - Coordinate binary builds with main release workflow - Attach binaries to existing draft release
mkdir -p dist | ||
docker run --rm --platform linux/amd64 \ | ||
-v $(pwd):/workspace -w /workspace \ | ||
golang:1.23.4-bookworm \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope we can make this golang:1.23.4-bookworm
matching our globally set golang version..
We typically bump it in one place.
mkdir -p dist | ||
|
||
# Build for linux/amd64 | ||
echo "Building for linux/amd64..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know for sure we don't need a build for Mac ARM? (I see this becomes very common in OSS)
FYI. pre-commit fails because CI already bumped
We will need to update our code and PR separately to get you unblocked. Then you will need to rebase. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3484 +/- ##
==========================================
+ Coverage 56.98% 57.39% +0.40%
==========================================
Files 218 217 -1
Lines 32519 32238 -281
==========================================
- Hits 18532 18503 -29
+ Misses 12088 11826 -262
- Partials 1899 1909 +10 ☔ View full report in Codecov by Sentry. |
This workflow handles the automated build and release process for Charon binaries. Key features include:
Cross-Platform Build Support:
Version Management:
Release Artifacts:
Release Process:
The workflow ensures reliable, reproducible builds while maintaining a clear and organized release process.
category: fixbuild
ticket: none