Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/eth1wrap: add support for smart contract based signature #3510

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DiogoSantoss
Copy link
Contributor

@DiogoSantoss DiogoSantoss commented Feb 6, 2025

Add support for eth1 client for smart contract based signature support.
Add --execution-rpc-api CLI flag to specify the JSON-RPC API endpoint.

category: feature
ticket: #3458

@DiogoSantoss DiogoSantoss changed the title WIP: eth1 client app/eth1wrap: eth1 client Feb 6, 2025
@DiogoSantoss DiogoSantoss changed the title app/eth1wrap: eth1 client app/eth1wrap: add support for smart contract based signature Feb 6, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 19.65318% with 139 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (55769e0) to head (750e5a3).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
app/eth1wrap/generated/erc1271.go 0.00% 56 Missing ⚠️
app/eth1wrap/client.go 23.72% 45 Missing ⚠️
cluster/definition.go 7.69% 12 Missing ⚠️
cmd/combine.go 0.00% 12 Missing ⚠️
app/disk.go 0.00% 3 Missing ⚠️
cmd/dkg.go 0.00% 3 Missing ⚠️
cmd/manifest_tools.go 0.00% 1 Missing and 1 partial ⚠️
cluster/lock.go 50.00% 0 Missing and 1 partial ⚠️
cmd/combine/combine.go 85.71% 0 Missing and 1 partial ⚠️
cmd/createcluster.go 85.71% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   57.40%   57.28%   -0.12%     
==========================================
  Files         217      219       +2     
  Lines       32245    32431     +186     
==========================================
+ Hits        18509    18577      +68     
- Misses      11826    11946     +120     
+ Partials     1910     1908       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant