Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fixed loaded keys ordering #3524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pinebit
Copy link
Collaborator

@pinebit pinebit commented Feb 12, 2025

In create cluster using --split-keys charon loads keystores in unordered fashion. In other places we apply SequencedKeys() that sorts the keys by index. Applied the same logic to create cluster implementation.

category: bug
ticket: none

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.41%. Comparing base (aa7b9fd) to head (e961535).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3524   +/-   ##
=======================================
  Coverage   57.40%   57.41%           
=======================================
  Files         217      217           
  Lines       32289    32289           
=======================================
+ Hits        18536    18539    +3     
  Misses      11839    11839           
+ Partials     1914     1911    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants