Rebase latest upstream changes #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hoodi
Add JDs dockerfile
fix docker entrypoint/cmd
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Oisín Kyne <[email protected]>
Push docker image building action
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
263
to
313
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./helios-ts | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Setup Rust | ||
| uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: stable | ||
| default: true | ||
| override: true | ||
|
|
||
| - name: Cache Rust dependencies | ||
| uses: Swatinem/rust-cache@v2 | ||
|
|
||
| - name: Install Node.js dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build helios-ts package | ||
| run: npm run build | ||
|
|
||
| - name: Create npm package tarball | ||
| id: pack | ||
| run: | | ||
| PACKAGE_FILENAME=$(npm pack) | ||
| echo "Packed file: $PACKAGE_FILENAME" | ||
| echo "::set-output name=package_filename::$PACKAGE_FILENAME" | ||
| - name: Generate tag name | ||
| id: tag | ||
| # This step runs in the workspace root, not ./helios-ts default | ||
| working-directory: ${{ github.workspace }} | ||
| run: | | ||
| echo "::set-output name=release_tag::nightly-${GITHUB_SHA}" | ||
| - name: Release npm package to GitHub Releases | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| tag_name: ${{ steps.tag.outputs.release_tag }} | ||
| prerelease: true | ||
| files: helios-ts/${{ steps.pack.outputs.package_filename }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the issue, we will add a permissions block at the root of the workflow file. This block will define the minimal permissions required for the workflow to function. Specifically:
contents: readis needed for accessing repository files.packages: writeis required for publishing npm packages.pull-requests: writeis required for interacting with pull requests.issues: writeis required for creating or updating issues.actions: writeis required for interacting with GitHub Actions artifacts.
The permissions block will be added at the top level of the workflow file, ensuring it applies to all jobs unless overridden by a job-specific permissions block.
Suggested changeset
1
.github/workflows/release.yml
| @@ -5,2 +5,9 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| pull-requests: write | ||
| issues: write | ||
| actions: write | ||
|
|
||
| jobs: |
Copilot is powered by AI and may make mistakes. Always verify output.
|
Getting hit with rate limits on alchemy and infura running this many tests in parallel. Moving forward anyways. |
Signed-off-by: Oisín Kyne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.