Skip to content

Commit

Permalink
fix: cache route not read props (#95)
Browse files Browse the repository at this point in the history
* fix: cache route not read props

* fix: local variable
  • Loading branch information
iNorthIsle authored Jan 14, 2022
1 parent a6bbce7 commit 54686a4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/auth/src/providers/github.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class GithubProvider extends BaseProvider {

get project () {
if(process.env.NODE_ENV === 'development') {
return local
return 'local'
}
if(process.env.NODE_ENV === 'test') {
return `${process.env.PROJECT}-test`
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-components/src/Tabs/TabbedExplorer.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export default class TabbedExplorer extends PureComponent {
<Page
cacheLifecycles={props.cacheLifecycles}
onDisplay={this.onPageDisplay}
value={props.match.params.value}
value={props.match?.params?.value}
tabs={this.tabs.current}
{...otherProps}
/>
Expand Down

0 comments on commit 54686a4

Please sign in to comment.