-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Keystone Correction and Post Projection Scale #32
base: main
Are you sure you want to change the base?
Conversation
@Maxiriton , thank you for your PR! What problem does the post scale feature solve for you? Why not use the aspect ratio? At first glance I would think that this could work against the throw ratio and you could end up simulating a projector that is not physically constrained. |
Hello @Ocupe , Sorry for the late answer ! I did these changes upon request from my client who is a director/scenographer and uses Projector for their Theater work. Here are his anwser : The keystone is an arbitrary value, and each beamer has it owns scale for it, so it goes from -X to +X. Based on your comments, I think it would be nice to lock the post scale feature in a percentage and not allow a scale that would increase the size of the projected image. Thanks, |
bump version number
Hello,
In this pull request I've implemented vertical and horizontal keystone correction. To do so, I had to change some node in the projection group, but I tried to changed these changes as minimal as possible.
Another feature is the post scale feature. It adds the posibility for users to globally scale the projected image on top of all others parameters.
These changes are done in order to mimic real world projectors. I hope you'll find them usefull.