feat: migrate CI to arbitrum-testnode composite action#683
Open
douglance wants to merge 4 commits into
Open
Conversation
Replace the live run-nitro-test-node build with the prebuilt OffchainLabs/arbitrum-testnode@v0.2.7 composite action across the v3.2 and v2.1 custom-gas-token integration matrix (6 & 18 decimals), and refresh the audit allowlist.
…ridge reads - createRollup: thread RollupCreator v2.1 vs v3.2 differences through fee, call-value, custom-fee-token allowance/approval, and transaction-request building. - createTokenBridge: let getTokenBridgeContracts / createTokenBridge accept a tokenBridgeCreatorAddressOverride so the inbox->deployment mapping is read from the creator that performed the deployment, not the chain default.
Read deployment metadata (rollup-creator, L3 chain-owner upgrade executor) from the testnode config, fund deployer accounts with the custom fee token (scaled to the token's decimals), route owner actions through the L3-side upgrade executor, and query the freshly-deployed token bridge creator.
The testnode emits the RollupCreator address in l3deployment.json (rollup-creator) for every variant CI uses, so read it directly instead of scanning RollupCreated logs via eth_getLogs. discoverRollupCreatorAddress only ran when the value was zero, which never happens for the custom-fee variants, so this is a behavior-preserving cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffchainLabs/actions/run-nitro-test-node@feat-simplifywithOffchainLabs/arbitrum-testnode@v0.2.0(snapshot-based, ~10s boot vs ~12min)getInformationFromTestnode()to read config from filesystem (ARBITRUM_TESTNODE_CONFIG_DIR) with docker exec fallback for local devl2-nodeConfig.json,l3-nodeConfig.json) and batch posterprivate-key→ address derivation{v2.1, v3.2} × {6, 18}using structured action inputsDepends on
nitro-contracts-versioninput)nctag formatTest plan
pnpm buildpassespnpm lintpassespnpm test:unit— 38 files, 193 tests passpnpm test:type— 2 files, 9 tests pass