Fix lint problems #698
Merged
Fix lint problems #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was created by: 1. Copying over nitro's `.golangci.yml` 2. Running `golangci-lint run --fix` 3. Addressing the remaining issues except for gosec G115 4. Temporarily disabling gsec G115
Most of the test helpers in the standard libraries (and, indeed in go code across the open-source world) use try to keep the arguments of types from the testing package at the front of each function's signature (except if there is a context.Context object, in which case, that one goes before the one from the testing library types.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was created by:
.golangci.ymlgolangci-lint run --fix