Skip to content

hashdb cap and commit batch size config options #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

hashdb cap and commit batch size config options #452

wants to merge 20 commits into from

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented May 7, 2025 •
edited
Loading

This PR:

  • adds two new config options to core.CacheConfig :
    • TrieCapBatchSize - write batch size threshold used during capping triedb size
    • TrieCommitBatchSize - write batch size threshold used during committing triedb to disk
  • adds internal pebble batch size checks in ethdb/pebble.batch.Put and ethdb/pebble.batch.Delete to return an error instead of getting panic from the internals of pebble

part of NIT-3204

@cla-bot cla-bot bot added the s CLA signed label May 7, 2025
@magicxyyz magicxyyz mentioned this pull request May 7, 2025
Open
@magicxyyz magicxyyz self-assigned this May 23, 2025
@magicxyyz magicxyyz marked this pull request as ready for review May 27, 2025 21:01
@magicxyyz magicxyyz removed their assignment May 27, 2025
@magicxyyz magicxyyz marked this pull request as draft May 27, 2025 21:30
@magicxyyz magicxyyz marked this pull request as ready for review May 28, 2025 12:58
diegoximenes
diegoximenes requested changes May 28, 2025
View reviewed changes
@magicxyyz magicxyyz requested a review from diegoximenes July 17, 2025 15:59
@magicxyyz magicxyyz assigned diegoximenes and unassigned magicxyyz Jul 17, 2025
diegoximenes
diegoximenes requested changes Jul 22, 2025
View reviewed changes
@magicxyyz magicxyyz assigned diegoximenes and unassigned magicxyyz Jul 23, 2025
@magicxyyz magicxyyz requested a review from diegoximenes July 23, 2025 18:28
@diegoximenes diegoximenes assigned tsahee and unassigned diegoximenes Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegoximenes diegoximenes diegoximenes approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees

@tsahee tsahee

Labels

s CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magicxyyz @diegoximenes @tsahee @eljobe