refactor: unroll macros in x86-64 assembly for Clang compatibility #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace GNU as-specific .equ/.equiv dynamic reassignment with C preprocessor #define macros and manually unroll all .rept loops with explicit register rotation patterns. This enables compilation with Clang's integrated assembler (and thus Zig's SDK) without requiring -fno-integrated-as flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
Author
|
cc @siddarthkay as your PR may need to be reverted if this works. Would be nice to test on LLVM 21+ |
Contributor
|
@potuz: sure can test using hashtree from this branch in nimbus CI and report back. |
prestonvanloon
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace GNU as-specific .equ/.equiv dynamic reassignment with C preprocessor #define macros and manually unroll all .rept loops with explicit register rotation patterns. This enables compilation with Clang's integrated assembler (and thus Zig's SDK) without requiring -fno-integrated-as flag.
🤖 Generated with Claude Code