Add a BigMap contract for testing the storage trie #295
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PlasmaPower, I'm not sure what all the CI failures mean. Did I do something wrong? |
|
Some of the failures are because the contract isn't formatted correctly. I'd fix that and see what's still failing. The audit is probably just not passing on the base branch, so I think we can merge it without that one passing. |
PlasmaPower
reviewed
Jan 31, 2025
|
sorry, I missed this PR when releasing 2.1.3; do we need a release tag for this mock or we are ok with just merging this into the permanent |
Co-authored-by: Pepper Lebeck-Jobe <[email protected]>
gzeoneth
approved these changes
Feb 5, 2025
|
We don't need a release for this, this is just for nitro unit tests so it just needs to be in the nitro pin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contracts makes it easy to add a bunch of storage slots in a single transation, and then in a separate transaction to free a bunch of those slots and add some others.
The idea is that this sort of operation will pass with the deterministic flag on the storage db implementation set and fail when it is not set.
Part of NIT-3068