Add ArbFilteredTransactionsManager precompile #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
from
3e44be1 to
682dbab
Compare
4 tasks
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
2 times, most recently
from
a3ff4ab to
33abc0f
Compare
Tristan-Wilson
approved these changes
Dec 29, 2025
MishkaRogachev
changed the title
MishkaRogachev
force-pushed
the
create-arbcensoredtransactionsmanager-precompile
branch
from
101d31e to
3033065
Compare
diegoximenes
approved these changes
Jan 13, 2026
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
LGTM, assigning to @MishkaRogachev to merge, or to assign to someone with merging power, when nitro PR is ready to be merged.
gzeoneth
approved these changes
Jan 16, 2026
ArbOwnerPublic.sol
Outdated
| address filterer | ||
| ) external view returns (bool); | ||
|
|
||
| /// @notice Retrieves the list of transaction filterers |
Member
There was a problem hiding this comment.
Suggested change
| /// @notice Retrieves the list of transaction filterers | |
| /// @notice Retrieves the list of transaction filterers |
ArbOwner.sol
Outdated
| address filterer | ||
| ) external view returns (bool); | ||
|
|
||
| /// @notice Retrieves the list of transaction filterers |
Member
There was a problem hiding this comment.
Suggested change
| /// @notice Retrieves the list of transaction filterers | |
| /// @notice Retrieves the list of transaction filterers |
| /// @notice Checks whether the given transaction hash is filtered | ||
| /// @param txHash The transaction hash to check | ||
| /// @return True if filtered, false otherwise | ||
| function isTransactionFiltered( |
Member
There was a problem hiding this comment.
is this going to be public or only usable by authorized filterer?
Contributor
Author
There was a problem hiding this comment.
Since there is an event that allows this information to be obtained, I think the method should be public so that there is no ambiguity
gligneul
approved these changes
Jan 16, 2026
Member
|
@MishkaRogachev, is this one also ready for a final review? |
eljobe
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of NIT-4245
pulled in by OffchainLabs/nitro#4174
Changes: