Add ArbFilteredTransactionsManager precompile #4174

MishkaRogachev · 2025-12-24T14:21:45Z

Fixes NIT-4152 and NIT-4253
pulls in OffchainLabs/nitro-precompile-interfaces#25
pulls in OffchainLabs/go-ethereum#604
pulls in OffchainLabs/nitro-testnode#169

Changes:

Add new precompile ArbFilteredTransactionsManager to manage filtered transactions
Add transaction censors to ArbOs and ArbOwner to limit access to ArbFilteredTransactionsManager
Add an account, separated from ArbOs state, to store filtered transactions
Limit filtered transactions feature with ArbCensoredTransactionManagerFromTime

codecov · 2025-12-24T15:10:03Z

Codecov Report

❌ Patch coverage is 28.04233% with 136 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.48%. Comparing base (8dff9a2) to head (2058741).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4174      +/-   ##
==========================================
- Coverage   33.12%   29.48%   -3.64%     
==========================================
  Files         462      464       +2     
  Lines       55958    56132     +174     
==========================================
- Hits        18534    16549    -1985     
- Misses      34168    36582    +2414     
+ Partials     3256     3001     -255

github-actions · 2025-12-24T15:50:16Z

❌ 6 Tests Failed:

Tests completed	Failed	Passed	Skipped
4469	6	4463	0

View the top 3 failed tests by shortest run time

TestEndToEnd_ManyEvilValidators

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369051 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369005 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231183
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369045 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

TestEndToEnd_ManyEvilValidators/honest_essential_edges_confirmed_by_challenge_win

Stack Traces | -0.000s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369051 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369005 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231183
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

goroutine 3369045 [select]:
github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast.func1()
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:108 +0xc5
created by github.com/offchainlabs/nitro/bold/containers/events.(*Producer[...]).Broadcast in goroutine 231189
	/home/runner/work/nitro/nitro/bold/containers/events/producer.go:107 +0xca

TestRedisProduceComplex/one_producer,_all_consumers_are_active

Stack Traces | 1.240s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[01-13|19:58:48.563] Redis stream consuming                   �[36mconsumer_id�[0m=9a8e3dc2-a5cc-4158-b780-2d42df45b6bf �[36mmessage_id�[0m=1768334327481-2
�[36mDEBUG�[0m[01-13|19:58:48.563] consumer: xack                           �[36mcid�[0m=7f6d3a90-efbb-40f2-acf3-e9996476e592 �[36mmessageId�[0m=1768334327481-0
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: setting result                 �[36mcid�[0m=9a8e3dc2-a5cc-4158-b780-2d42df45b6bf �[36mmsgIdInStream�[0m=1768334327481-2  �[36mresultKeyInRedis�[0m=result-key:stream:bd34045a-2767-4d32-82e8-fc6e5fbf0e0f.1768334327481-2
�[36mDEBUG�[0m[01-13|19:58:48.563] consumer: xack                           �[36mcid�[0m=983a2145-d97d-4424-afcd-cb386cff495b �[36mmessageId�[0m=1768334327481-1
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: xack                           �[36mcid�[0m=9a8e3dc2-a5cc-4158-b780-2d42df45b6bf �[36mmessageId�[0m=1768334327481-2
�[33mWARN �[0m[01-13|19:58:48.564] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1768334327463-1
�[33mWARN �[0m[01-13|19:58:48.564] XClaimJustID returned empty response when indicating heartbeat �[33mmsgID�[0m=1768334327463-0
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: xdel                           �[36mcid�[0m=9aaf5f30-8b7c-4199-85ce-64c9fa10b92c �[36mmessageId�[0m=1768334327461-5
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: xdel                           �[36mcid�[0m=9a8e3dc2-a5cc-4158-b780-2d42df45b6bf �[36mmessageId�[0m=1768334327481-2
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: xdel                           �[36mcid�[0m=983a2145-d97d-4424-afcd-cb386cff495b �[36mmessageId�[0m=1768334327481-1
�[36mDEBUG�[0m[01-13|19:58:48.564] consumer: xdel                           �[36mcid�[0m=7f6d3a90-efbb-40f2-acf3-e9996476e592 �[36mmessageId�[0m=1768334327481-0
�[36mDEBUG�[0m[01-13|19:58:48.565] Redis stream consuming                   �[36mconsumer_id�[0m=46c83632-207a-4d1d-8de1-076c41c0cbd8 �[36mmessage_id�[0m=1768334327481-3
�[36mDEBUG�[0m[01-13|19:58:48.565] consumer: setting result                 �[36mcid�[0m=46c83632-207a-4d1d-8de1-076c41c0cbd8 �[36mmsgIdInStream�[0m=1768334327481-3  �[36mresultKeyInRedis�[0m=result-key:stream:bd34045a-2767-4d32-82e8-fc6e5fbf0e0f.1768334327481-3
�[36mDEBUG�[0m[01-13|19:58:48.565] consumer: xack                           �[36mcid�[0m=46c83632-207a-4d1d-8de1-076c41c0cbd8 �[36mmessageId�[0m=1768334327481-3
�[36mDEBUG�[0m[01-13|19:58:48.566] consumer: xdel                           �[36mcid�[0m=46c83632-207a-4d1d-8de1-076c41c0cbd8 �[36mmessageId�[0m=1768334327481-3
�[36mDEBUG�[0m[01-13|19:58:48.603] checkResponses                           �[36mresponded�[0m=88 �[36merrored�[0m=0 �[36mchecked�[0m=98
�[36mDEBUG�[0m[01-13|19:58:48.609] redis producer: check responses starting
�[36mDEBUG�[0m[01-13|19:58:48.615] checkResponses                           �[36mresponded�[0m=10 �[36merrored�[0m=0 �[36mchecked�[0m=10
�[36mDEBUG�[0m[01-13|19:58:48.680] Error destroying a stream group          �[36merror�[0m="dial tcp 127.0.0.1:40401: connect: connection refused"
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (1.24s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Tristan-Wilson

Looks good, just a minor comment about consistency of the interface with other precompiles.

Tristan-Wilson · 2025-12-29T15:32:32Z

precompiles/ArbFilteredTransactionsManager.go

+	return filteredState.IsFiltered(txHash)
+}
+
+func (con ArbFilteredTransactionsManager) hasAccess(c *Context) (bool, error) {


This signature is slightly different to ArbNativeTokenManager which has

func (con ArbNativeTokenManager) hasAccess(c ctx) bool { manager, err := c.State.NativeTokenOwners().IsMember(c.caller) return manager && err == nil }

and therefore the behavior when there is an error is slightly different in this implementation in that if there is an error, then the gas is not burned out.

Unsure if this difference is intentional or not.

Tristan-Wilson · 2025-12-29T16:40:43Z

We should consider making ArbFilteredTransactionsManager calls free for transaction censors, similar to how ArbOwner calls are free for chain owners. Currently, censors pay gas for AddFilteredTransaction/DeleteFilteredTransaction, but since they're trusted actors authorized by chain owners, it would make sense to follow the same pattern. This could be done by creating a CensorPrecompile wrapper (similar to OwnerPrecompile in wrapper.go) that checks TransactionCensors().IsMember(caller) and returns gasSupplied with multigas.ZeroGas() on success.

MishkaRogachev · 2025-12-29T17:52:20Z

This could be done by creating a CensorPrecompile wrapper (similar to OwnerPrecompile in wrapper.go) that checks TransactionCensors().IsMember(caller) and returns gasSupplied with multigas.ZeroGas() on success.

@Tristan-Wilson, wdyt about going further: remove ArbNativeToken-style check and return an error right in CensorPrecompile, like in ArbOwner?

Tristan-Wilson · 2025-12-30T12:37:22Z

system_tests/filtered_transactions_test.go

+	"github.com/offchainlabs/nitro/solgen/go/precompilesgen"
+)
+
+func TestManageTransactionCensors(t *testing.T) {


Can you please also test that the transactions that should be free are free? You can look at TestArbNativeTokenManager and getGasUsed inside it for inspiration.

I don't really get how to use getGasUsed in this case, since the transaction will still cost something, only the add/delete call is free. I can suggest to use multigas like this:

tx, err = arbFilteredTxs.AddFilteredTransaction(&censorTxOpts, txHash) require.NoError(t, err) receipt, err := builder.L2.EnsureTxSucceeded(tx) require.NoError(t, err) require.Equal(t, uint64(0), receipt.MultiGasUsed.Get(multigas.ResourceKindStorageAccess))

This somehow proves that tx did not perform any storage operations like set and clear

Could you check the censor account's balance is unchanged after adding/deleting filtered txs?

This precompile wrapper does not make the transaction completely free, but I still believe that this test is useful because it allows to verify that the call goes through the wrapper

…anager

diegoximenes · 2026-01-13T17:19:26Z

precompiles/wrapper.go

+		evm,
+	)
+	if err != nil {
+		return output, gasSupplied, multigas.ZeroGas(), err


Gas charging decision based on if the caller is a filterer should be done independently of this err.
With current implementation, if the caller is not authorized, then this err will not be nil, and multigas.ZeroGas() will be charged.
This is not the wanted behavior.

Also, how about adding a test, that would have caught this?
Not sure yet if it is straightforward to do this test though, so we can discuss it out of github if you find it will take too much time to implement, and evaluate if it is worth to add it.

Good catch, I overlooked it. I don’t see how this exact issue is reachable from a system test, so I added a precompile-level test

diegoximenes · 2026-01-13T17:29:08Z

system_tests/filtered_transactions_test.go

+
+	// Initially neither owner nor user can modify filtered transactions,
+	// but both can read (get) filtered status
+	_, err = arbFilteredTxs.IsTransactionFiltered(ownerCallOpts, txHash)


nitpick: check that returned value is false.

diegoximenes · 2026-01-13T17:31:00Z

system_tests/filtered_transactions_test.go

+		}
+		ev, parseErr := arbOwner.ParseTransactionFiltererAdded(*lg)
+		if parseErr != nil {
+			continue


nitpick: why continuing instead of requiring that parseErr is nil?

This was referenced Dec 24, 2025

Add ArbFilteredTransactionsManager precompile OffchainLabs/nitro-precompile-interfaces#25

Open

core: Add FilteredTransactionsManager config and address OffchainLabs/go-ethereum#604

Open

MishkaRogachev changed the title ~~Add ArbCensoredTransactionsManager precompile (idle)~~ Add ArbCensoredTransactionsManager precompile Dec 24, 2025

MishkaRogachev force-pushed the create-arbcensoredtransactionsmanager-precompile branch from 1adc79f to 81f4e5e Compare December 24, 2025 14:55

MishkaRogachev force-pushed the create-arbcensoredtransactionsmanager-precompile branch 2 times, most recently from 45fb413 to 67c13f2 Compare December 26, 2025 15:01

MishkaRogachev changed the title ~~Add ArbCensoredTransactionsManager precompile~~ Add ArbFilteredTransactionsManager precompile Dec 26, 2025

MishkaRogachev force-pushed the create-arbcensoredtransactionsmanager-precompile branch 3 times, most recently from 7b7a735 to f56f36c Compare December 29, 2025 12:06

This was referenced Dec 29, 2025

Add ArbFilteredTransactionsManager.abi OffchainLabs/blockscout#207

Open

Update blockscout pin OffchainLabs/nitro-testnode#169

Open

MishkaRogachev marked this pull request as ready for review December 29, 2025 13:48

MishkaRogachev requested review from Tristan-Wilson, diegoximenes and tsahee December 29, 2025 13:48

Tristan-Wilson self-assigned this Dec 29, 2025

Tristan-Wilson requested changes Dec 29, 2025

View reviewed changes

Tristan-Wilson assigned MishkaRogachev and Copilot and unassigned Tristan-Wilson and Copilot Dec 29, 2025

MishkaRogachev assigned Tristan-Wilson and unassigned MishkaRogachev Dec 30, 2025

MishkaRogachev requested a review from Tristan-Wilson December 30, 2025 11:00

Tristan-Wilson reviewed Dec 30, 2025

View reviewed changes

MishkaRogachev added 15 commits January 12, 2026 16:12

Separated kv-storage for censored transactions

987a143

Rename: censored -> filtered transactions

bbce75c

chore: minor fixes

28feb69

Add a system test for filtered transaction manager

1ad1084

Make ArbFilteredTransactionsManager access similar to ArbNativeTokenM…

0a6b8bb

…anager

Add CensorPrecompile wrapper to make transaction filtring free

18a4b46

Add events for filtered transaction

102cbf9

Add test for free calls for FilteredTransactionsManager

cc5818a

Add limited GetTransactionCensorshipFromTime

b0085c9

Finalise limited GetTransactionCensorshipFromTime

fb009fe

Add TransactionFilteringEnabled to ArbOS state init

fa1ca8a

Improve tests and polish comments

64d5725

Review fixes and polishing

d5690a1

Make IsTransactionFiltered public

55dea76

Add events and public methods for transaction filterers

b82304e

MishkaRogachev force-pushed the create-arbcensoredtransactionsmanager-precompile branch from 2fad658 to 85d7766 Compare January 12, 2026 15:40

MishkaRogachev assigned diegoximenes and unassigned MishkaRogachev Jan 12, 2026

tmp: add stubs to compile upstream version

9d83f9c

MishkaRogachev force-pushed the create-arbcensoredtransactionsmanager-precompile branch from 85d7766 to 9d83f9c Compare January 12, 2026 16:18

Add test for filterer add/remove event

bcb35a9

MishkaRogachev assigned Tristan-Wilson and unassigned diegoximenes Jan 13, 2026

diegoximenes requested changes Jan 13, 2026

View reviewed changes

diegoximenes assigned MishkaRogachev and unassigned Tristan-Wilson Jan 13, 2026

Review fixes and minor polishing

2058741

MishkaRogachev requested a review from diegoximenes January 13, 2026 19:53

MishkaRogachev assigned diegoximenes and unassigned MishkaRogachev Jan 13, 2026

Add ArbFilteredTransactionsManager precompile #4174

Are you sure you want to change the base?

Add ArbFilteredTransactionsManager precompile #4174

Conversation

MishkaRogachev commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 6 Tests Failed:

Uh oh!

Tristan-Wilson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tristan-Wilson commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MishkaRogachev commented Dec 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diegoximenes Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MishkaRogachev commented Dec 24, 2025 •

edited

Loading

codecov bot commented Dec 24, 2025 •

edited

Loading

github-actions bot commented Dec 24, 2025 •

edited

Loading

Tristan-Wilson commented Dec 29, 2025 •

edited

Loading

diegoximenes Jan 13, 2026 •

edited

Loading