Skip to content

Conversation

@MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Oct 1, 2025

Fixes NIT-3555
Waits #3755 (temporary contains changes from this PR)

@eljobe eljobe added the after-next-version This PR shouldn't be merged until after the next version is released label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2142 3 2139 0
View the top 3 failed tests by shortest run time
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.240s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1567d30, 0xc000189500}, {0x154d800, 0xc00168c5c0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 245
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
    protocol_test.go:248: goroutine 253 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.2/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1567d30, 0xc000189500}, {0x154d800, 0xc00210c2a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 245
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.24s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.260s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.26s)
TestValidationInputsAtWithWasmTarget
Stack Traces | 3.110s run time
=== RUN   TestValidationInputsAtWithWasmTarget
=== PAUSE TestValidationInputsAtWithWasmTarget
=== CONT  TestValidationInputsAtWithWasmTarget
    validation_inputs_at_test.go:70: goroutine 1491672 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.2/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40820f0, 0xc06e380380}, {0x403fec0, 0xc0a3685c40}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc06e380380, {0x403fec0, 0xc0a3685c40}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestValidationInputsAtWithWasmTarget(0xc06e380380)
        	/home/runner/work/nitro/nitro/system_tests/validation_inputs_at_test.go:70 +0x970
        testing.tRunner(0xc06e380380, 0x3cca7a8)
        	/opt/hostedtoolcache/go/1.25.2/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.2/x64/src/testing/testing.go:1997 +0x465
        
    validation_inputs_at_test.go:70: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
--- FAIL: TestValidationInputsAtWithWasmTarget (3.11s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@gligneul gligneul assigned MishkaRogachev and unassigned gligneul Oct 1, 2025
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch from 607fe96 to 50f5462 Compare October 1, 2025 13:32
@MishkaRogachev MishkaRogachev marked this pull request as draft October 2, 2025 12:52
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch from 50f5462 to 9e6594a Compare October 3, 2025 17:34
@MishkaRogachev MishkaRogachev changed the base branch from master to gligneul/multi-dimensional-resource-constraints October 3, 2025 17:37
@MishkaRogachev MishkaRogachev changed the base branch from gligneul/multi-dimensional-resource-constraints to master October 3, 2025 17:37
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch 3 times, most recently from a1585bf to 8424424 Compare October 6, 2025 10:09
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 6, 2025 10:09
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch from 8424424 to cf66e2b Compare October 6, 2025 10:21
@gligneul gligneul removed their assignment Oct 6, 2025
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch from d9ce0f3 to b10a912 Compare October 7, 2025 12:39
@MishkaRogachev MishkaRogachev force-pushed the constraint-based-pricing-model-impl branch from b10a912 to d2f17b3 Compare October 7, 2025 13:42
@MishkaRogachev MishkaRogachev marked this pull request as draft October 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

after-next-version This PR shouldn't be merged until after the next version is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants