Skip to content

Conversation

@MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Oct 7, 2025

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2160 4 2156 0
View the top 3 failed tests by shortest run time
TestOutOfGasInStorageCacheFlush
Stack Traces | 2.990s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[10-22|11:58:49.276] Allowed origin(s) for WS RPC interface [http://localhost http://runnervmwhb2z]
INFO [10-22|11:58:49.276] WebSocket enabled                        url=ws://127.0.0.1:33299
=== PAUSE TestOutOfGasInStorageCacheFlush
=== CONT  TestOutOfGasInStorageCacheFlush
    program_test.go:2813: goroutine 681710 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x408c450, 0xc0b4084540}, {0x4049e80, 0xc0d122a8e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0b4084540, {0x4049e80, 0xc0d122a8e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1758 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc0b4084540)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc0b4084540, 0x3cd33a0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
--- FAIL: TestOutOfGasInStorageCacheFlush (2.99s)
TestVersion40
Stack Traces | 5.480s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion40
=== CONT  TestVersion40
    precompile_inclusion_test.go:90: goroutine 454974 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x408c450, 0xc065fbea80}, {0x404a300, 0xc09203c900}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc065fbea80, {0x404a300, 0xc09203c900}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1758 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc065fbea80, 0x28, {0xc047a83df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc065fbea80?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc065fbea80, 0x3cd3878)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (5.48s)
TestTimeboostTxsTimeoutByBlock
Stack Traces | 20.250s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=16  size=3.18KiB   time="39.694µs"  gcnodes=552  gcsize=102.92KiB  gctime=1.452908ms  livenodes=161   livesize=32.33KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="43.51µs"   gcnodes=568  gcsize=106.14KiB  gctime=1.496288ms  livenodes=145   livesize=29.11KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=17  size=3.29KiB   time="37.92µs"   gcnodes=585  gcsize=109.43KiB  gctime=1.534067ms  livenodes=128   livesize=25.82KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="38.411µs"  gcnodes=601  gcsize=112.65KiB  gctime=1.572307ms  livenodes=112   livesize=22.60KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=16  size=3.22KiB   time="39.103µs"  gcnodes=617  gcsize=115.87KiB  gctime=1.611259ms  livenodes=96    livesize=19.38KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=15  size=3.08KiB   time="36.938µs"  gcnodes=632  gcsize=118.95KiB  gctime=1.648077ms  livenodes=81    livesize=16.30KiB
DEBUG[10-22|12:02:48.318] Dereferenced trie from memory database   nodes=16  size=3.21KiB   time="38.321µs"  gcnodes=648  gcsize=122.16KiB  gctime=1.686267ms  livenodes=65    livesize=13.09KiB
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=16  size=3.21KiB   time="37.5µs"    gcnodes=664  gcsize=125.37KiB  gctime=1.723657ms  livenodes=49    livesize=9.88KiB
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=16  size=3.21KiB   time="37.309µs"  gcnodes=680  gcsize=128.58KiB  gctime=1.760835ms  livenodes=33    livesize=6.67KiB
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=17  size=3.35KiB   time="38.772µs"  gcnodes=697  gcsize=131.93KiB  gctime=1.799456ms  livenodes=16    livesize=3.32KiB
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=16  size=3.32KiB   time="39.774µs"  gcnodes=713  gcsize=135.25KiB  gctime=1.839089ms  livenodes=0     livesize=0.00B
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=0   size=0.00B     time=220ns       gcnodes=713  gcsize=135.25KiB  gctime=1.839199ms  livenodes=0     livesize=0.00B
DEBUG[10-22|12:02:48.319] Dereferenced trie from memory database   nodes=0   size=0.00B     time=201ns       gcnodes=713  gcsize=135.25KiB  gctime=1.83927ms   livenodes=0     livesize=0.00B
INFO [10-22|12:02:48.319] Blockchain stopped
TRACE[10-22|12:02:48.324] P2P networking is spinning down
ERROR[10-22|12:02:48.326] Context closed, autonomous auctioneer shutting down
INFO [10-22|12:02:48.326] Context done while waiting redis streams to be ready, failed to start
ERROR[10-22|12:02:48.326] Context closed, autonomous auctioneer shutting down
ERROR[10-22|12:02:48.327] Consuming request                        error="reading message for consumer: \"e40af5d0-fdb0-4dc4-9cb8-1b4dab48abf9\": context canceled"
--- FAIL: TestTimeboostTxsTimeoutByBlock (20.25s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the check-multi-dimensional-gas-in-block-re-execution branch from 8380e75 to f76ff64 Compare October 8, 2025 09:30
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 8, 2025 10:27
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

gligneul
gligneul previously approved these changes Oct 8, 2025
@gligneul gligneul assigned eljobe and unassigned gligneul Oct 8, 2025
@MishkaRogachev MishkaRogachev force-pushed the check-multi-dimensional-gas-in-block-re-execution branch from 425b696 to 151a997 Compare October 15, 2025 14:55
eljobe
eljobe previously approved these changes Oct 22, 2025
@eljobe eljobe added this pull request to the merge queue Oct 22, 2025
Merged via the queue into master with commit 907ecd7 Oct 22, 2025
25 checks passed
@eljobe eljobe deleted the check-multi-dimensional-gas-in-block-re-execution branch October 22, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants