Skip to content

remote signer gloas - #16852

Merged
james-prysm merged 10 commits into
developfrom
remote-signer-gloas
Sep 4, 2026
Merged

remote signer gloas#16852
james-prysm merged 10 commits into
developfrom
remote-signer-gloas

Conversation

@james-prysm

@james-prysm james-prysm commented May 27, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

adds the following types to web3signer

Type Domain Signer role
EXECUTION_PAYLOAD_ENVELOPE DOMAIN_BEACON_BUILDER (0x0B000000) Builder
PAYLOAD_ATTESTATION_MESSAGE DOMAIN_PTC_ATTESTER (0x0C000000) PTC attester
PROPOSER_PREFERENCES DOMAIN_PROPOSER_PREFERENCES (0x0D000000) Proposer
BUILDER_REQUEST_AUTH DOMAIN_BUILDER_REQUEST_AUTH (0x0B000001) Proposer

Which issues(s) does this PR fix?

implements ethereum/remote-signing-api#28

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have included a uniquely named changelog fragment file.
  • I have added a description with sufficient context for reviewers to understand this PR.
  • I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).

@james-prysm

Copy link
Copy Markdown
Contributor Author

#17063 make sure to implement request auth too

@james-prysm
james-prysm marked this pull request as ready for review September 3, 2026 18:37
@james-prysm
james-prysm requested a review from a team as a code owner September 3, 2026 18:37

@syjn99 syjn99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EXECUTION_PAYLOAD_BID is missing here (it's in PR description) - do we have to implement in Prysm side?

@syjn99 syjn99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway I couldn't find any divergence between spec and the implementation, and most of the code follows the existing pattern so LGTM

@james-prysm
james-prysm added this pull request to the merge queue Sep 4, 2026
Merged via the queue into develop with commit 6c7106c Sep 4, 2026
26 checks passed
@james-prysm
james-prysm deleted the remote-signer-gloas branch September 4, 2026 16:46
@github-project-automation github-project-automation Bot moved this from Unassigned to Done in Gloas Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants