-
Notifications
You must be signed in to change notification settings - Fork 907
Update sample from Bot Builder SDK to Teams PR-6 #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
8bd591e
c0fbebb
ab25a03
2b885ab
db873cb
a6ae4d8
7240a64
9e33cc7
7bc312e
2cccd7e
fbd589a
9052505
7bd5790
1e4b7ad
51addd1
50bf2de
279d621
78ace60
352c082
0030343
ded9cb7
5c1fe97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this file is usually gitignored.. what's the reason to commit it?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <Solution> | ||
| <Project Path="AdaptiveCardActions/AdaptiveCardActions.csproj" /> | ||
| <Project Path="M365Agent/M365Agent.atkproj" Type="a9e3f50b-275e-4af7-adce-8be12d41e305"> | ||
| <Deploy /> | ||
| </Project> | ||
| </Solution> |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,52 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <LangVersion>latest</LangVersion> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <LangVersion>14.0</LangVersion> | ||
|
||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="AdaptiveCards.Rendering.Html" Version="2.7.3" /> | ||
| <PackageReference Include="AdaptiveCards.Templating" Version="1.3.2" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="6.0.11" /> | ||
| <PackageReference Include="Microsoft.Bot.Builder.Integration.AspNet.Core" Version="4.18.1" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.13.1" /> | ||
| <PackageReference Include="Microsoft.Teams.Api" Version="2.0.*" /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reference only the top level package
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you only need Plugins.AspNetCore, all the other packages are transitive dependencies and dont need to be in the csproj |
||
| <PackageReference Include="Microsoft.Teams.Apps" Version="2.0.*" /> | ||
| <PackageReference Include="Microsoft.Teams.Plugins.AspNetCore" Version="2.0.*" /> | ||
| <PackageReference Include="Microsoft.Teams.Common" Version="2.0.*" /> | ||
| <PackageReference Include="AdaptiveCards.Templating" Version="1.6.0" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> | ||
|
||
| </ItemGroup> | ||
|
|
||
| <!-- Exclude old Bot Builder files from compilation --> | ||
| <ItemGroup> | ||
|
||
| <Content Update="appsettings.json"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| <Compile Remove="csharp\**" /> | ||
| <Content Remove="csharp\**" /> | ||
| <EmbeddedResource Remove="csharp\**" /> | ||
| <None Remove="csharp\**" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Exclude generated PolySharp files --> | ||
| <ItemGroup> | ||
| <Compile Remove="obj\**\PolySharp.SourceGenerators\**\*.g.cs" /> | ||
|
||
| </ItemGroup> | ||
|
|
||
| <!-- Exclude local settings from publish --> | ||
| <ItemGroup> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove, use defaults
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed. |
||
| <Content Remove="appsettings.Development.json" /> | ||
| <Content Include="appsettings.Development.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| <CopyToPublishDirectory>None</CopyToPublishDirectory> | ||
| </Content> | ||
| <Content Remove="appsettings.Playground.json" /> | ||
| <Content Include="appsettings.Playground.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| <CopyToPublishDirectory>None</CopyToPublishDirectory> | ||
| </Content> | ||
| </ItemGroup> | ||
|
|
||
|
|
||
| <!-- Include Cards folder in output --> | ||
| <ItemGroup> | ||
| <Folder Include="Images\" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| <None Include="Cards\**\*.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
| </Project> | ||



There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having one action per sample/language will lead to 202 actions. We should have only one, or one per language max.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the file, we will update one single file.