Skip to content

Conversation

@tecton
Copy link
Contributor

@tecton tecton commented Jan 7, 2026

Pull Request

Description

Type of Change

  • New sample onboarding (internal - source code in this repo)
  • New sample onboarding (external - source code in another repo)
  • Sample update/fix
  • Documentation update
  • Validation tool update
  • Other (Release)

For New Sample Onboarding

Checklist

  • I have added/updated the sample entry in .config/samples-config-v3.json
  • I have included a README.md with setup instructions
  • I have included a thumbnail image with correct aspect ratio (40:23, e.g., 1600×920 or 800×460)

Validation Results (Required)

Important: You must run the validation tool locally and provide a screenshot of the results.

For Internal Samples (source code in this repo)

cd validation-tool
npm install
node validator.cjs -p ../<your-sample-folder>

For External Samples (source code in another repo)

cd validation-tool
npm install

# Clone your sample repo (sparse checkout recommended)
git clone --filter=blob:none --sparse <your-repo-url>
cd <repo-name>
git sparse-checkout set <path-to-sample>
cd ..

# Run validation
node validate-external.js <sample-id> ./<repo-name>

Related Issues

if any question related to validation, may refer to the Sample Validation Guide
if still has questions, may open a issue :)

wh-alice and others added 30 commits November 10, 2025 13:59
fix: teams ai library sample image size
fix: deploy issue for teams ai samples
fix: remove 2 samples until they are ready
fix: change tenant id of sso connection for travel agent
fix: cherry-pick change tenant id of sso connection for travel agent
* Add proxyAgent

* Fix documentation & Product names

Applied fix for PR
Product rename
Allign names in all documentation

* Naming Update
* Add proxyAgent

* Fix documentation & Product names

Applied fix for PR
Product rename
Allign names in all documentation

* Naming Update

* Updates

V1 final updates.
hardcoded SDK versions until GA
Updated Readme with demo video
Updated Agent Flow in Readme to better align with the real flow.

* Minor fix

Update to support latest SDK with fixed version

* last fixes

last sync to get Readme and Manifest updates

* Update Readme
delete collab agent as atk already onboard it as a template
…g repos's thumbnail's resolution. change gif img to be option as it is not used now
fix: pipeline validation and delete collaborator-agent sample because it already a template
fix: coffee agent manifests short name
- intelligent-data-chart-generator/api: Add @types/node and upgrade TypeScript to 5.6.3
- hello-world-tab-with-backend/api: Add @types/node and upgrade TypeScript to 5.6.3
- todo-list-with-Azure-backend-M365: Remove devTool/install action that fails in CI

Issues:
- TypeScript 4.x is incompatible with @types/node@25 (transitive dep from mssql)
- devTool/install fails with DotnetInstallationError even when .NET is installed
…nd-M365

The devTool/install action is required for downloading Agent Playground
to simulate Teams client for bot debugging.

The actual fix for DotnetInstallationError is in fx-core's dotnetChecker.ts
which needs to support .NET 7.0/8.0/9.0 versions.
…with comments

Both useEffect hooks are intentionally designed to run only once on mount:
- useData: auto-fetch initial data once, user calls reload() manually afterwards
- useTeams: initialize Teams SDK and register event handlers once

Added eslint-disable-next-line with explanatory comments to clarify the intent.
This fixes CI build failure where warnings are treated as errors.
qfai and others added 5 commits January 5, 2026 15:16
fix: resolve build failures for intelligent-data-chart-generator, hello-world-tab-with-backend, and todo-list-with-Azure-backend-M365
* fix: change prompt to function call and add known issue in readme

* add data-analysis sample to config

* fix sample image files

* fix sample's remote deploy issue

* add sql.js dependency

* fix new sample onboard date

* Update sql-generation.ts

* Update ac.ts

* Update sql.ts

* fix additionalMetadata

* fix: add support to validate sampletag

* add external validation and pr requirement

* update pull request template

* add sample tag for hello-world-office-addin and incoming-webhook-notification project

* using empty dev env to only track telemetry

* add m365agent.yml version validation

* fix external validator

* remove prompt, just use pull request template and validation tool is enough

* fix: resolve comments

* fix: resovle comments
…gent naming (#1560)

* Initial plan

* Add ProxyAgent-NodeJS sample to samples config

Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com>

* Fix terminology and tag consistency for ProxyAgent-NodeJS

Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com>

* Update ProxyAgent samples title and tags per feedback

Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com>

* Mark ProxyAgent-NodeJS as featured sample

Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com>

* fix: sample validation

* fix: exclude a365 variables

* fix: update validate script

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com>
Co-authored-by: Huihui Wu <huihuiwu@microsoft.com>
…1562)

* fix(bot-sso): resolve OBO token exchange failure in Azure MSI mode

- Replace @azure/identity OnBehalfOfCredential with direct MSAL ConfidentialClientApplication
  to avoid version conflicts between @azure/identity and @azure/msal-node that cause
  'network_error: Network request failed' during OBO token exchange

- Fix duplicate OBO issue: pass already-exchanged access token to commands instead of
  original SSO token, eliminating unnecessary second OBO call in showUserProfile.ts

- Update showUserProfile.ts to use the pre-exchanged access token directly with Graph API

Bug: 35872822

* fix(bot-sso-docker): resolve OBO token exchange failure in Azure MSI mode

- Replace @azure/identity OnBehalfOfCredential with direct MSAL ConfidentialClientApplication
  to avoid version conflicts between @azure/identity and @azure/msal-node that cause
  'network_error: Network request failed' during OBO token exchange

- Fix duplicate OBO issue: pass already-exchanged access token to commands instead of
  original SSO token, eliminating unnecessary second OBO call in showUserProfile.ts

- Update showUserProfile.ts to use the pre-exchanged access token directly with Graph API

Same fix as bot-sso sample (Bug: 35872822)
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

qfai added 2 commits January 7, 2026 13:05
…1565)

* Revert "fix(bot-sso): resolve OBO token exchange failure in Azure MSI mode (#1562)"

This reverts commit 6bb497a.

* fix: sso problem msal-node package version conflict

* fix for bot-sso-docker
@tecton tecton closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants