Skip to content

feat: support broker authentication for VSC and CLI #14925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HuihuiWu-Microsoft wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

feat: support broker authentication for VSC and CLI #14925

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
1770697
feat: support broker when login
HuihuiWu-Microsoft Aug 7, 2025
e01870e
feat: only enable broker for windows platform
HuihuiWu-Microsoft Aug 11, 2025
880612e
feat: adopt interactive function calling
HuihuiWu-Microsoft Aug 12, 2025
d47b07e
fix: get cached accounts from pca
HuihuiWu-Microsoft Aug 15, 2025
ebc1caf
fix: build fail
HuihuiWu-Microsoft Nov 13, 2025
c82a33d
fix: build error with keytar
HuihuiWu-Microsoft Nov 13, 2025
e217523
fix: upgrade package to fix broker plugin not available issue
HuihuiWu-Microsoft Dec 2, 2025
a5b294c
fix: mock keytar and bundle msal node runtime with esbuild
HuihuiWu-Microsoft Dec 2, 2025
8c7ca98
feat: popup broker in front of vsc window
HuihuiWu-Microsoft Dec 2, 2025
65b129b
feat: differentiate broker auth with browser auth
HuihuiWu-Microsoft Dec 5, 2025
ee7af15
fix: fallback to legacy browser flow with success page
HuihuiWu-Microsoft Dec 5, 2025
d3c1733
fix: force refresh with claim since broker auth doesnt support forceR…
HuihuiWu-Microsoft Dec 5, 2025
1d15955
fix: build error
HuihuiWu-Microsoft Dec 8, 2025
eda8b91
test: fix ut
HuihuiWu-Microsoft Dec 8, 2025
66729bf
fix: use pca instead of msalTokenCache since it doesnt support broker
HuihuiWu-Microsoft Dec 10, 2025
2514f3b
test: fix ut
HuihuiWu-Microsoft Dec 15, 2025
d020ed2
fix: only force refresh token when no tenanted account
HuihuiWu-Microsoft Dec 16, 2025
84aa3cc
fix: unit test failure on linux
HuihuiWu-Microsoft Dec 16, 2025
feee297
test: fix vsc ut
HuihuiWu-Microsoft Dec 16, 2025
2884b52
test: fix vsc package ut exception due to keytar
HuihuiWu-Microsoft Dec 16, 2025
b73acd9
fix: merge conflict
HuihuiWu-Microsoft Dec 16, 2025
d2a6b0f
test: fix UT mock issue
HuihuiWu-Microsoft Dec 18, 2025
81f45b5
test: add ut to raise code cov
HuihuiWu-Microsoft Dec 18, 2025
04d6f1c
test: add ut to raise code cov
HuihuiWu-Microsoft Dec 18, 2025
e729d60
revert: unexpected localized files change
HuihuiWu-Microsoft Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/chai-spies": "^1.0.3",
"@types/fs-extra": "^9.0.10",
"@types/mocha": "^8.2.2",
"@types/node": "^14.14.10",
"@types/node": "^18.15.3",
"@types/sinon": "^9.0.10",
"@typescript-eslint/eslint-plugin": "^4.19.0",
"@typescript-eslint/parser": "^4.19.0",
Expand All @@ -57,7 +57,7 @@
"prettier": "^2.4.1",
"sinon": "^9.2.2",
"source-map-support": "^0.5.19",
"ts-node": "^9.1.1",
"ts-node": "^10.8.1",
"tslint-config-prettier": "^1.18.0",
"typescript": "^5.0.4"
},
Expand Down
98 changes: 83 additions & 15 deletions packages/api/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 12 additions & 11 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
"watch": "rimraf lib && npm run copy-files && tsc -w -p ./",
"package": "rimraf lib && node --max-old-space-size=4096 node_modules/webpack/bin/webpack.js --mode production --config ./webpack.config.js",
"prepack": "npm run package",
"test:unit": "nyc --no-clean mocha \"tests/unit/**/*.tests.ts\" ",
"test:helper": "nyc --no-clean mocha \"tests/unit/helper.tests.ts\" ",
"test:engine": "nyc --no-clean mocha \"tests/unit/engine.tests.ts\" ",
"test:cmds": "nyc --no-clean mocha \"tests/unit/cmds/**/*.tests.ts\" ",
"test:commands": "nyc --no-clean mocha \"tests/unit/commands.tests.ts\" ",
"test:telemetry": "nyc --no-clean mocha \"tests/unit/telemetry.tests.ts\" ",
"test:prompts": "nyc --no-clean mocha \"tests/unit/prompts/**/*.tests.ts\" ",
"test:unit": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/**/*.tests.ts\" ",
"test:helper": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/helper.tests.ts\" ",
"test:engine": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/engine.tests.ts\" ",
"test:cmds": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/cmds/**/*.tests.ts\" ",
"test:commands": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/commands.tests.ts\" ",
"test:telemetry": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/telemetry.tests.ts\" ",
"test:prompts": "nyc --no-clean mocha --require tests/unit/setup.ts \"tests/unit/prompts/**/*.tests.ts\" ",
"check-format": "prettier --list-different --config .prettierrc.json --ignore-path .prettierignore \"{src,tests}/**/*.ts\" \"*.{js,json}\"",
"format": "prettier --write --config .prettierrc.json --ignore-path .prettierignore \"{src,tests}/**/*.ts\" \"*.{js,json}\"",
"lint:fix": "eslint \"src/**/*.ts\" \"tests/**/*.ts\" --fix",
Expand Down Expand Up @@ -59,7 +59,7 @@
"@types/keytar": "^4.4.2",
"@types/lodash": "^4.14.170",
"@types/mocha": "^8.0.4",
"@types/node": "^14.14.21",
"@types/node": "^18.15.3",
"@types/semver": "^7.5.1",
"@types/sinon": "^9.0.10",
"@types/underscore": "^1.11.0",
Expand Down Expand Up @@ -90,9 +90,9 @@
"style-loader": "^2.0.0",
"terser-webpack-plugin": "^5.1.2",
"ts-loader": "^9.2.2",
"ts-node": "^9.1.1",
"ts-node": "^10.8.1",
"tslib": "^2.3.1",
"typescript": "^4.5.5",
"typescript": "^5.0.0",
"umd-compat-loader": "^2.1.2",
"url-loader": "^4.1.1",
"uuid": "^8.3.2",
Expand All @@ -104,6 +104,7 @@
"@azure/core-auth": "^1.4.0",
"@azure/identity": "^4.1.0",
"@azure/msal-node": "^2.6.6",
"@azure/msal-node-extensions": "^1.5.25",
"@inquirer/core": "^5.1.2",
"@inquirer/prompts": "^6.0.0",
"@inquirer/type": "^1.1.5",
Expand All @@ -118,7 +119,7 @@
"express": "^4.21.2",
"figures": "^3.2.0",
"fs-extra": "^9.1.0",
"lodash": "^4.17.21",
"lodash": "^4.17.21",
"node-machine-id": "^1.1.12",
"open": "^8.2.1",
"semver": "^7.5.4",
Expand Down
Loading
Loading