Skip to content

Conversation

@qfai
Copy link
Contributor

@qfai qfai commented Dec 31, 2025

Summary

This PR fixes multiple failing Sample E2E tests by addressing issues in the test infrastructure and fx-core.

Sample E2E Test Status

Status Count
✅ Fixed (this PR) 4
🔧 PR Pending (external repos) 4
🗑️ Removed 2

Test Cases Detail

Test Status Issue Fix
ProvisionStockUpdate ✅ Fixed Bot ID validation failed - bicep uses clientId but validator expected CLIENT_ID Fixed in botValidator.ts
ProvisionBotSSO ✅ Fixed Same as above Same fix
ProvisionLargeScaleNotiBot ✅ Fixed Same as above Same fix
ProvisionTodoListM365 ✅ Fixed dotnetChecker only recognized .NET 3.1/5.0/6.0, CI has 8.0 Added .NET 7.0/8.0/9.0 support
ProvisionNpmSearch 🗑️ Removed Sample plan to deprecate Test file deleted
ProvisionIntelligentDataChart 🔧 External PR TypeScript 4.x incompatible with @types/node@25 PR in samples repo
ProvisionHelloWorldTabBackEnd 🔧 External PR TypeScript + ESLint warnings as errors in CI PR in samples repo
ProvisionSignatureOutlook External PR merged YAML version: 1.0.0 needs upgrade to v1.2 PR in Office-Add-in-samples
ProvisionChefBot 🗑️ Removed no longer in sample config Test file deleted
ProvisionProactiveMessage 🔧External PR Azure Bot MultiTenant deprecated, needs SingleTenant config Fix needed in Microsoft-Teams-Samples

Related E2E pipeline run

https://github.com/OfficeDev/microsoft-365-agents-toolkit/actions/runs/20614282695

qfai added 5 commits December 30, 2025 14:06
…cker

The devTool/install action was failing with DotnetInstallationError because
dotnetChecker only supported .NET 3.1/5.0/6.0 but CI uses .NET 8.0.

This fix adds .NET 7.0, 8.0, and 9.0 to the supportedVersions array so that
the checker can detect and use newer .NET installations.
@qfai qfai merged commit b211c9f into dev Jan 5, 2026
45 of 51 checks passed
@qfai qfai deleted the quke/fixsamplee2e branch January 5, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants