-
Notifications
You must be signed in to change notification settings - Fork 278
fix(e2e): Fix sample E2E test failures #15076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cker The devTool/install action was failing with DotnetInstallationError because dotnetChecker only supported .NET 3.1/5.0/6.0 but CI uses .NET 8.0. This fix adds .NET 7.0, 8.0, and 9.0 to the supportedVersions array so that the checker can detect and use newer .NET installations.
HuihuiWu-Microsoft
approved these changes
Jan 5, 2026
Alive-Fish
approved these changes
Jan 5, 2026
tecton
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple failing Sample E2E tests by addressing issues in the test infrastructure and fx-core.
Sample E2E Test Status
Test Cases Detail
clientIdbut validator expectedCLIENT_IDbotValidator.tsdotnetCheckeronly recognized .NET 3.1/5.0/6.0, CI has 8.0@types/node@25version: 1.0.0needs upgrade tov1.2Related E2E pipeline run
https://github.com/OfficeDev/microsoft-365-agents-toolkit/actions/runs/20614282695