Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(auth): add addAuthAction command in core #13046

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

KennethBWSong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.87179% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (897ccb6) to head (4d478d4).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
packages/fx-core/src/core/FxCore.ts 84.21% 1 Missing and 2 partials ⚠️
.../fx-core/src/component/generator/apiSpec/helper.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #13046      +/-   ##
==========================================
+ Coverage   90.21%   90.22%   +0.01%     
==========================================
  Files         581      581              
  Lines       34871    34945      +74     
  Branches     6938     6920      -18     
==========================================
+ Hits        31458    31529      +71     
- Misses       1488     1489       +1     
- Partials     1925     1927       +2     
Files with missing lines Coverage Δ
packages/fx-core/src/question/constants.ts 96.96% <100.00%> (+<0.01%) ⬆️
packages/fx-core/src/question/create.ts 92.07% <100.00%> (ø)
packages/fx-core/src/question/index.ts 95.83% <100.00%> (+0.18%) ⬆️
packages/fx-core/src/question/other.ts 87.36% <100.00%> (+1.95%) ⬆️
.../fx-core/src/component/generator/apiSpec/helper.ts 94.43% <66.66%> (+0.01%) ⬆️
packages/fx-core/src/core/FxCore.ts 89.84% <84.21%> (-0.12%) ⬇️

@KennethBWSong KennethBWSong merged commit ad64394 into dev Jan 15, 2025
19 checks passed
@KennethBWSong KennethBWSong deleted the bowsong/add_auth_core branch January 15, 2025 03:25
huimiu pushed a commit that referenced this pull request Jan 27, 2025
* perf(auth): add addAuthAction command in core

* fix: update api

* test: add ut

* test: add ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants