Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(auth): add nofitication for addAuthConfig command #13064

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

KennethBWSong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (3b8dd69) to head (ac2f7ed).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...vscode-extension/src/handlers/lifecycleHandlers.ts 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #13064      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         583      583              
  Lines       34977    34974       -3     
  Branches     6990     6948      -42     
==========================================
- Hits        31561    31557       -4     
  Misses       1489     1489              
- Partials     1927     1928       +1     
Files with missing lines Coverage Δ
packages/cli/src/commands/models/addAuthConfig.ts 100.00% <100.00%> (ø)
...code-extension/src/telemetry/extTelemetryEvents.ts 100.00% <100.00%> (ø)
...vscode-extension/src/handlers/lifecycleHandlers.ts 92.85% <85.71%> (-0.39%) ⬇️

... and 4 files with indirect coverage changes

Alive-Fish
Alive-Fish previously approved these changes Jan 17, 2025
void vscode.window
.showInformationMessage(
localize("teamstoolkit.handeler.addAuthConfig.notification"),
"Provision"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this button need localization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@KennethBWSong KennethBWSong merged commit 0ade4f8 into dev Jan 20, 2025
19 checks passed
@KennethBWSong KennethBWSong deleted the bowsong/add_auth_notification branch January 20, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants