refactor(fx-core): scaffold question and generator refactor #13106
+3,721
−2,588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/refactor-question
…e/refactor-question
… huajie/refactor-question
tecton
changed the title
anchenyi
previously approved these changes
Feb 8, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hund030
previously approved these changes
Feb 8, 2025
yuqizhou77
reviewed
Feb 8, 2025
| function checkDeclarativeCopilot(inputs: Inputs) { | ||
| return inputs[QuestionNames.Capabilities] === CapabilityOptions.declarativeAgent().id; | ||
| } | ||
| export const specGenerator = new SpecGenerator(); |
There was a problem hiding this comment.
typo? I am guessing you want to export CopilotExtensionGenerator
tecton
reviewed
Feb 8, 2025
| import { TemplateNames } from "../templateNames"; | ||
| import { Template } from "./interface"; | ||
|
|
||
| export const copilotPluginTemplates: Template[] = [ |
There was a problem hiding this comment.
This data will be moved to me.ts.
…into nintan/refactor
anchenyi
reviewed
Feb 8, 2025
| return TemplateNames.DefaultBot; | ||
| } | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
missing Declarative Agent? Need to make sure all templates are listed here, otherwise the single select list will b empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataproperty.activatefunction.TODO: Refactor specGenerator to multiple generators in following PR.