Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate encoding::gamma and its content #427

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Deprecate encoding::gamma and its content #427

merged 1 commit into from
Jan 12, 2025

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Jan 12, 2025

Deprecates Gamma, GammaFn and F2p2 due to being incorrectly implemented and being more error prone than just implementing FromLinear and IntoLinear for a custom type.

The current implementation of GammaFn has the FromLinear and IntoLinear implementations reversed, and fixing that would break code that compensates for the error. Deprecation, together with the extended number of RGB standards added recently, should hopefully provide better alternatives without suddenly changing the visual output of existing uses.

The recommended migration options are to either find a fitting alternative in palette::encoding or implementing FromLinear and IntoLinear for a custom type. Suggestions for more additions are also welcome.

Copy link

codspeed-hq bot commented Jan 12, 2025

CodSpeed Performance Report

Merging #427 will degrade performances by 19.68%

Comparing deprecate_gamma (9cf298b) with master (234309c)

Summary

❌ 1 regressions
✅ 46 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master deprecate_gamma Change
matrix_inverse 352.5 ns 438.9 ns -19.68%

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (234309c) to head (9cf298b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   82.63%   82.69%   +0.06%     
==========================================
  Files         131      131              
  Lines       20485    20457      -28     
  Branches    20485    20457      -28     
==========================================
- Hits        16927    16917      -10     
  Misses       3378     3378              
+ Partials      180      162      -18     
Components Coverage Δ
palette 82.75% <ø> (+0.06%) ⬆️
palette_derive 81.98% <ø> (ø)

@Ogeon Ogeon merged commit 5d22ea1 into master Jan 12, 2025
22 of 23 checks passed
@Ogeon Ogeon deleted the deprecate_gamma branch January 12, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant