implemented palette angle/bool_mask/num traits for simba's Wide* wrapper types

[kije]

Implements the angle/bool_mask/num traits for simba's Wide* wrapper types behind a simba feature flag.

Note: to activate the implementation, both the wide and the simba feature must be enabled.

Closed Issues

• Closes Implement num/bool_mask/angle traits for Wide* types of the simba crate #430, by implementing palette's "primitive" traits for simba's wide wrappers

[Ogeon]

Thank you! I'm going to be a bit busy today, so I may wait with a proper review until later, but I skimmed through it and it looks good so far.

[codspeed-hq]

CodSpeed Performance Report

Merging #431 will not alter performance

_{Comparing kije:master (32a6dc5) with master (fac0b2e)}

Summary

✅ 47 untouched benchmarks

[kije]

I don't think the last failing no_std test/check in CI is related to my changes

error[E0557]: feature has been removed
 --> no_std_test/src/main.rs:1:42
  |
1 | #![cfg_attr(feature = "nightly", feature(start))]
  |                                          ^^^^^ feature has been removed
  |
  = note: not portable enough and never RFC'd

error: cannot find attribute `start` in this scope
  --> no_std_test/src/main.rs:10:3
   |
10 | #[start]
   |   ^^^^^
   |
   = note: `start` is in scope, but it is a function, not an attribute

error[E0[60](https://github.com/Ogeon/palette/actions/runs/13945384633/job/39033052288?pr=431#step:4:61)1]: `main` function not found in crate `no_std_test`
  --> no_std_test/src/main.rs:30:13
   |
30 | fn main() {}
   |             ^ consider adding a `main` function to `no_std_test/src/main.rs`

[Ogeon]

Yeah, it looks like they changed some things on nightly. 🤔 I can look into it when I'm free and let you know when it should work again, unless someone else gets to it first.

[Ogeon]

The no_std test has been updated. You can rebase your branch to bring the change in. I have also eyed through the changes again and I think we just need to relax the features a bit to not pull in std. Speaking of, it may be a good opportunity to extend the all_features feature in the no_std_test crate with palette/wide and palette/simba to verify the setup.

Also, Palette doesn't use the feat:, etc. prefixes for anything, so you can drop them from the commits and PR. I'll ask you to squash everything at the end, so feel free to wait until then. 🙂

But thanks again for submitting this and also for adding the unit tests! 🎉

[Ogeon]

Let's also disable default features so we don't impose more than we use. We may have to add opt-ins for std and libm with that, similar to wide.

[kije]

Thanks for the review and suggestions. I rebased my branch, and implemented your suggestion regarding no_std_test and prevented pulling in std when not enabled via palette's std feature.

Hope that is what you meant :)

[Ogeon]

Yes, thank you! I'm just wondering now if some of them can be skipped, if they aren't strictly necessary for the implementation here. 🤔 I looked around a bit and we can perhaps skip enabling most or all of them on wide and simba. Palette should only enable those that are necessary for compiling itself, after all.

Sorry for the back and forth, let me know if you rather prefer to move on.

[Ogeon]

Oh, it looks like simba + wide has some issues with no_std 👀 https://github.com/Ogeon/palette/actions/runs/14018720715/job/39248266654?pr=431