Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LOWER for pgsql driver because it's redundant #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HawtDogFlvrWtr
Copy link

Because you're forcing ILIKE when using the pgsql driver, you only need to cast to text and not lower. Lowering clobbers all indexes, making it impossible to improve query speeds. The below ILIKE when using pgsql takes care of lower and upper searches while still leaving the cast above for dates etc.

Because you're forcing ILIKE when using the pgsql driver, you only need to cast to text and not lower. Lowering clobbers all indexes, making it impossible to improve query speeds. The below ILIKE when using pgsql takes care of lower and upper searches while still leaving the cast above for dates etc.
@Okipa
Copy link
Owner

Okipa commented Nov 16, 2023

Thanks for you PR, could you please pull the master and fix failing tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants