Skip to content

unify(worldbuilder): Move unified WorldBuilder to Core - #3

Closed
OmarAglan wants to merge 0 commit into
unify/worldbuilder-mergefrom
unify/worldbuilder-core
Closed

unify(worldbuilder): Move unified WorldBuilder to Core#3
OmarAglan wants to merge 0 commit into
unify/worldbuilder-mergefrom
unify/worldbuilder-core

Conversation

@OmarAglan

@OmarAglan OmarAglan commented Jul 28, 2026

Copy link
Copy Markdown
Owner

What changed

  • Moved the unified WorldBuilder implementation and shared resources to Core/Tools/WorldBuilder.
  • Added the corei_worldbuilder interface target.
  • Reduced the Generals and Zero Hour WorldBuilder directories to thin executable wrappers.
  • Preserved both game-specific splash bitmaps and selected them through the target's game compile definition.

Why

After the two implementations are synchronized, keeping duplicate source trees creates unnecessary drift. Core now owns the shared implementation while each game retains its target name, dependencies, output name, and compile definition.

Impact

Generals and Zero Hour compile the same Core WorldBuilder sources with their respective RTS_GENERALS or RTS_ZEROHOUR definition.

Validation

  • CMake configure and generation succeeded for the shared interface and both wrappers
  • Generated resource rules contain the correct game compile definition
  • Resource preprocessing selects WorldBuilderV.bmp for Generals and WorldBuilderZH.bmp for Zero Hour
  • Core CMake manifest contains all 198 source/header files
  • git diff --check
  • Exactly one commit relative to the WorldBuilder merge branch

Full MSVC/MFC compilation was not available in the local environment because cl.exe and msbuild.exe are absent.

Stack

3 of 3. Depends on TheSuperHackers#3025 (unify/worldbuilder-merge).

@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-merge branch from 93db098 to c56bc00 Compare July 28, 2026 10:44
@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-core branch from 0bcf3c4 to 27024f6 Compare July 28, 2026 10:44
@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-merge branch from c56bc00 to bc2980a Compare July 28, 2026 11:12
@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-core branch from 27024f6 to dc62ef5 Compare July 28, 2026 11:13
@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-merge branch from bc2980a to 0a40354 Compare July 28, 2026 11:17
@OmarAglan OmarAglan closed this Jul 28, 2026
@OmarAglan
OmarAglan force-pushed the unify/worldbuilder-core branch from dc62ef5 to 0a40354 Compare July 28, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant