unify(worldbuilder): Move unified WorldBuilder to Core - #4
Closed
OmarAglan wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Core/Tools/WorldBuilder.corei_worldbuilderinterface target.Why
After the two implementations are synchronized, keeping duplicate source trees creates unnecessary drift. Core now owns the shared implementation while each game retains its target name, dependencies, output name, and compile definition.
Impact
Generals and Zero Hour compile the same Core WorldBuilder sources with their respective
RTS_GENERALSorRTS_ZEROHOURdefinition.Validation
WorldBuilderV.bmpfor Generals andWorldBuilderZH.bmpfor Zero Hourgit diff --checkFull MSVC/MFC compilation was not available in the local environment because
cl.exeandmsbuild.exeare absent.Stack
3 of 3. Depends on TheSuperHackers#3025 (
unify/worldbuilder-merge).