Recreates Emby configuration page with a simpler layout.#4776
Recreates Emby configuration page with a simpler layout.#4776bernarden wants to merge 3 commits intoOmbi-app:developfrom
Conversation
|
I like it! I was toying around with the Plex settings the other day wondering how I can improve it. I like this approach |
|
I will resolve the merge conflicts in a few hours. Do you think any other changes are needed? |
bernarden
force-pushed
the
feature/new-emby-configuration-page
branch
from
3f8f3c9 to
044ba8e
Compare
|
Here is a screenshot of slightly adjusted margins: |
| }; | ||
| } | ||
|
|
||
| public processChangeEvent() { |
There was a problem hiding this comment.
It feels like we are recreating some of the built in validation of angular reactive forms here, we should probably use a form with the servers being a form array (it's what we have been moving the other pages to).
What do you think?
There was a problem hiding this comment.
I started off with an angular reactive form but found it easier to implement all the validation and rules this way. I found that I had to listen to every change event anyway to determine if server discovery is required again.
2 participants
This PR recreates Emby configuration page. All server configuration is now shown in dialogs instead of tabs. Fixes #4424.
I will create another PR for Jellyfin if you are happy with this layout.
New config page view:
Editing existing server:
Creating new server after clicking on "Discover Server" button:
