🐛 OMF-222 중복선택 응답이 csv로 추출되지 않는 버그 수정

[wonjuneee]

✨ Related Issue

• OMF-222 중복선택 응답이 csv로 추출되지 않는 버그 수정

---

📌 Task Details

• 문항 별 응답을 String에서 Set<String>으로 조회하도록 하여 중복선택 응답이 누락되지 않도록 수정

---

💬 Review Requirements (Optional)

Summary by CodeRabbit

새로운 기능

• 설문조사에서 한 질문에 대해 여러 답변을 지원합니다.

개선사항

• 설문 응답 데이터 내보내기 기능이 최적화되었습니다.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Note

.coderabbit.yml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'tools'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

📝 Walkthrough

Walkthrough

설문 응답 저장 구조를 단일 문자열에서 Set으로 변경하여 회원-질문 쌍당 여러 응답을 지원하도록 수정. 답변 맵 구성 시 각 (memberId, questionId)에 대해 Set으로 집계하고, 내보내기 시 Set을 toString()으로 문자열로 변환.

Changes

Cohort / File(s)	Summary
내부 데이터 구조 리팩토링 src/main/java/OneQ/OnSurvey/domain/survey/service/export/SurveyExportService.java	답변 저장 구조를 String에서 Set으로 변경하여 회원당 질문별 복수 응답을 지원. Set의 toString() 호출로 인한 null 처리 차이 발생 및 NPE 위험 가능성.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목이 PR의 주요 변경사항을 명확하게 요약하고 있으며, 버그 수정과 중복선택 응답 추출 문제를 직접 다루고 있습니다.
Description check	✅ Passed	PR 설명이 저장소의 템플릿 구조를 따르고 있으며, 관련 이슈, 작업 세부사항이 완전하게 포함되어 있습니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/OMF-222

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/main/java/OneQ/OnSurvey/domain/survey/service/export/SurveyExportService.java`:
- Around line 62-63: The code uses computeIfAbsent(a.getQuestionId(), k -> new
HashSet<>()).add(a.getContent()) which allows non-deterministic ordering;
replace the HashSet with LinkedHashSet to preserve insertion order for
consistent CSV export. Update the supplier passed to computeIfAbsent (in
SurveyExportService, around computeIfAbsent and add(a.getContent())) to return a
new LinkedHashSet<>() so duplicates are still eliminated but insertion order is
retained.
- Around line 93-96: In SurveyExportService where you build CSV rows (the loop
over headers using memberAnswers and SurveyQuestionHeader), avoid calling
.toString() on memberAnswers.get(h.getQuestionId()) which can be null and cause
NPE; instead retrieve the Set<String> value into a local (e.g., answersSet),
produce a safe String by checking for null/empty (use String.join(",",
answersSet) when non-null) and then pass that resulting String into nvl(...);
update the code that references memberAnswers.get(...) and nvl(...) to perform
the null check and join so empty/missing responses become an empty string rather
than throwing an exception or including bracketed Set.toString().