Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure loading spinner displays only when a trip is selected #197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iqbalcodes6602
Copy link

added conditionally rendering for the loaders and remove in other case

fixes: #191

@coveralls
Copy link

Coverage Status

coverage: 15.832% (-0.7%) from 16.487%
when pulling 36ea380 on iqbalcodes6602:Get-rid-of-the-full-page-loading
into 4220475 on OneBusAway:main.

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the linter and fix the issues it flags!

@iqbalcodes6602
Copy link
Author

iqbalcodes6602 commented Mar 6, 2025

Please run the linter and fix the issues it flags!

hi @aaronbrethorst , apologize for the issues. i didn't knew about the linter, have refactored the code as said.
Will do it for other pr also from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the full-page loading indicator on the Arrivals & Departures/Route Schedules page
3 participants